[Mac] Adopt kMTSupportNotification_ShouldPlayHDRVideoChanged notification
<rdar://problem/61173289>
Created attachment 397580 [details] Patch
Created attachment 397704 [details] Patch
Created attachment 397705 [details] Patch
Created attachment 397727 [details] Patch
Comment on attachment 397727 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397727&action=review > Source/WebKit/UIProcess/WebProcessPool.cpp:1127 > + registerHighDynamicRangeChangeCallback(); Nit: why not put this in the `#if !PLATFORM(MAC)` above rather than adding an empty `registerHighDynamicRangeChangeCallback` method to every port?
(In reply to Eric Carlson from comment #6) > Comment on attachment 397727 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=397727&action=review > > > Source/WebKit/UIProcess/WebProcessPool.cpp:1127 > > + registerHighDynamicRangeChangeCallback(); > > Nit: why not put this in the `#if !PLATFORM(MAC)` above rather than adding > an empty `registerHighDynamicRangeChangeCallback` method to every port? Because I have been vigorously instructed to avoid platform-specific code in non-platform specific classes.
Created attachment 397737 [details] Patch for landing
Created attachment 397797 [details] Patch for landing
Created attachment 397803 [details] Patch for landing
Committed r260832: <https://trac.webkit.org/changeset/260832> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397803 [details].
> Committed r260832: <https://trac.webkit.org/changeset/260832> This seems to have broken 7 layout-tests on windows, as also warned by EWS. Results database also points to this commit: https://results.webkit.org/?suite=layout-tests&test=fast%2Fdom%2Fbeforeload%2Fvideo-before-load.html&platform=win
Reopening to attach new patch.
Created attachment 397972 [details] Follow up fix
Committed r260907: <https://trac.webkit.org/changeset/260907> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397972 [details].