Bug 211028 - [Mac] Adopt kMTSupportNotification_ShouldPlayHDRVideoChanged notification
Summary: [Mac] Adopt kMTSupportNotification_ShouldPlayHDRVideoChanged notification
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-25 13:48 PDT by Jer Noble
Modified: 2020-04-29 11:53 PDT (History)
12 users (show)

See Also:


Attachments
Patch (50.81 KB, patch)
2020-04-25 13:52 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (54.68 KB, patch)
2020-04-27 11:31 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (54.70 KB, patch)
2020-04-27 11:43 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (54.72 KB, patch)
2020-04-27 13:23 PDT, Jer Noble
eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (54.60 KB, patch)
2020-04-27 14:24 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch for landing (54.85 KB, patch)
2020-04-27 21:13 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch for landing (54.61 KB, patch)
2020-04-27 21:46 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Follow up fix (2.02 KB, patch)
2020-04-29 09:55 PDT, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2020-04-25 13:48:33 PDT
[Mac] Adopt kMTSupportNotification_ShouldPlayHDRVideoChanged notification
Comment 1 Jer Noble 2020-04-25 13:51:39 PDT
<rdar://problem/61173289>
Comment 2 Jer Noble 2020-04-25 13:52:15 PDT
Created attachment 397580 [details]
Patch
Comment 3 Jer Noble 2020-04-27 11:31:23 PDT
Created attachment 397704 [details]
Patch
Comment 4 Jer Noble 2020-04-27 11:43:58 PDT
Created attachment 397705 [details]
Patch
Comment 5 Jer Noble 2020-04-27 13:23:04 PDT
Created attachment 397727 [details]
Patch
Comment 6 Eric Carlson 2020-04-27 13:29:24 PDT
Comment on attachment 397727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397727&action=review

> Source/WebKit/UIProcess/WebProcessPool.cpp:1127
> +    registerHighDynamicRangeChangeCallback();

Nit: why  not put this in the `#if !PLATFORM(MAC)` above rather than adding an empty `registerHighDynamicRangeChangeCallback` method to every port?
Comment 7 Jer Noble 2020-04-27 13:45:18 PDT
(In reply to Eric Carlson from comment #6)
> Comment on attachment 397727 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=397727&action=review
> 
> > Source/WebKit/UIProcess/WebProcessPool.cpp:1127
> > +    registerHighDynamicRangeChangeCallback();
> 
> Nit: why  not put this in the `#if !PLATFORM(MAC)` above rather than adding
> an empty `registerHighDynamicRangeChangeCallback` method to every port?

Because I have been vigorously instructed to avoid platform-specific code in non-platform specific classes.
Comment 8 Jer Noble 2020-04-27 14:24:49 PDT
Created attachment 397737 [details]
Patch for landing
Comment 9 Jer Noble 2020-04-27 21:13:42 PDT
Created attachment 397797 [details]
Patch for landing
Comment 10 Jer Noble 2020-04-27 21:46:38 PDT
Created attachment 397803 [details]
Patch for landing
Comment 11 EWS 2020-04-28 10:04:32 PDT
Committed r260832: <https://trac.webkit.org/changeset/260832>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397803 [details].
Comment 12 Aakash Jain 2020-04-29 04:17:03 PDT
> Committed r260832: <https://trac.webkit.org/changeset/260832>
This seems to have broken 7 layout-tests on windows, as also warned by EWS.

Results database also points to this commit: 
https://results.webkit.org/?suite=layout-tests&test=fast%2Fdom%2Fbeforeload%2Fvideo-before-load.html&platform=win
Comment 13 Jer Noble 2020-04-29 09:55:05 PDT
Reopening to attach new patch.
Comment 14 Jer Noble 2020-04-29 09:55:06 PDT
Created attachment 397972 [details]
Follow up fix
Comment 15 EWS 2020-04-29 11:53:49 PDT
Committed r260907: <https://trac.webkit.org/changeset/260907>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397972 [details].