Bug 211012 - Suppress ASan on DFG::clobberize() to work around an ASan bug.
Summary: Suppress ASan on DFG::clobberize() to work around an ASan bug.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-24 23:20 PDT by Mark Lam
Modified: 2020-04-25 00:25 PDT (History)
9 users (show)

See Also:


Attachments
proposed patch. (3.60 KB, patch)
2020-04-24 23:46 PDT, Mark Lam
ysuzuki: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2020-04-24 23:20:17 PDT
ASan was incorrectly thinking that we're accessing invalid stack memory when we're not.

<rdar://problem/62275430>
Comment 1 Mark Lam 2020-04-24 23:46:19 PDT
Created attachment 397545 [details]
proposed patch.
Comment 2 Yusuke Suzuki 2020-04-24 23:59:35 PDT
Comment on attachment 397545 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=397545&action=review

r=me

> Source/JavaScriptCore/dfg/DFGClobberize.h:43
> +SUPPRESS_ASAN void clobberize(Graph& graph, Node* node, const ReadFunctor& read, const WriteFunctor& write, const DefFunctor& def)

Can you add FIXME comment describing why SUPPRESS_ASAN is necessary (describing about ASAN bug)?
Comment 3 Mark Lam 2020-04-25 00:25:18 PDT
(In reply to Yusuke Suzuki from comment #2)
> Can you add FIXME comment describing why SUPPRESS_ASAN is necessary
> (describing about ASAN bug)?

Thanks for the review.  I've added the FIXME with explanation.

Landed in r260692: <http://trac.webkit.org/r260692>.