Bug 210999 – Add some debug output for run-jsc-stress-tests

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zhifei Fang]

Add some debug output for run-jsc-stress-tests

[Zhifei Fang]

Created attachment 397518 [details]
Patch

[Zhifei Fang]

I am using this to trigger a EWS to see where we hit for the JSC time out issue

[Zhifei Fang]

Most the timeout happened at the end of the running, it could be timeout in the detect failure stage, add these output to help me locate where are the timeout

[Jonathan Bedard]

Comment on attachment 397518 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397518&action=review

> Tools/ChangeLog:3
> +        Add some debug output for run-jsc-stress-tests

Can we embed some of the why in the commit message?

[Zhifei Fang]

Created attachment 397522 [details]
Patch

[Zhifei Fang]

(In reply to Jonathan Bedard from comment #4)
> Comment on attachment 397518 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=397518&action=review
> 
> > Tools/ChangeLog:3
> > +        Add some debug output for run-jsc-stress-tests
> 
> Can we embed some of the why in the commit message?

Added the radar link as well

[Zhifei Fang]

Created attachment 397736 [details]
Patch

[EWS]

Committed r260786: <https://trac.webkit.org/changeset/260786>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397736 [details].

[Radar WebKit Bug Importer]

<rdar://problem/62469359>

[Saam Barati]

Comment on attachment 397736 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397736&action=review

This should be behind an option, not the default. This prints each time you run it and it makes it seems like it might have failed.

> Tools/Scripts/run-jsc-stress-tests:2165
> +    puts "Detacted failures in #{Time.now - start_time}"

typo: Detacted => Detected