Bug 210999 - Add some debug output for run-jsc-stress-tests
Summary: Add some debug output for run-jsc-stress-tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zhifei Fang
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-24 15:28 PDT by Zhifei Fang
Modified: 2020-04-27 18:34 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.66 KB, patch)
2020-04-24 15:29 PDT, Zhifei Fang 		no flags Details | Formatted Diff | Diff
Patch (1.76 KB, patch)
2020-04-24 15:51 PDT, Zhifei Fang 		no flags Details | Formatted Diff | Diff
Patch (1.80 KB, patch)
2020-04-27 14:14 PDT, Zhifei Fang 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zhifei Fang 2020-04-24 15:28:44 PDT 
Add some debug output for run-jsc-stress-tests
Comment 1 Zhifei Fang 2020-04-24 15:29:15 PDT 
Created attachment 397518 [details]
Patch
Comment 2 Zhifei Fang 2020-04-24 15:29:55 PDT 
I am using this to trigger a EWS to see where we hit for the JSC time out issue
Comment 3 Zhifei Fang 2020-04-24 15:33:16 PDT 
Most the timeout happened at the end of the running, it could be timeout in the detect failure stage, add these output to help me locate where are the timeout
Comment 4 Jonathan Bedard 2020-04-24 15:49:18 PDT 
Comment on attachment 397518 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397518&action=review

> Tools/ChangeLog:3
> +        Add some debug output for run-jsc-stress-tests

Can we embed some of the why in the commit message?
Comment 5 Zhifei Fang 2020-04-24 15:51:40 PDT 
Created attachment 397522 [details]
Patch
Comment 6 Zhifei Fang 2020-04-24 15:52:18 PDT 
(In reply to Jonathan Bedard from comment #4)
> Comment on attachment 397518 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=397518&action=review
> 
> > Tools/ChangeLog:3
> > +        Add some debug output for run-jsc-stress-tests
> 
> Can we embed some of the why in the commit message?

Added the radar link as well
Comment 7 Zhifei Fang 2020-04-27 14:14:12 PDT 
Created attachment 397736 [details]
Patch
Comment 8 EWS 2020-04-27 14:38:03 PDT 
Committed r260786: <https://trac.webkit.org/changeset/260786>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397736 [details].
Comment 9 Radar WebKit Bug Importer 2020-04-27 14:39:14 PDT 
<rdar://problem/62469359>
Comment 10 Saam Barati 2020-04-27 18:34:27 PDT 
Comment on attachment 397736 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397736&action=review

This should be behind an option, not the default. This prints each time you run it and it makes it seems like it might have failed.

> Tools/Scripts/run-jsc-stress-tests:2165
> +    puts "Detacted failures in #{Time.now - start_time}"

typo: Detacted => Detected