Bug 210998 - OSR Exit compiler should know and print the exiting DFG node's index
Summary: OSR Exit compiler should know and print the exiting DFG node's index
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-24 15:22 PDT by Keith Miller
Modified: 2020-04-27 17:51 PDT (History)
7 users (show)

See Also:

Attachments
Patch (11.81 KB, patch)
2020-04-24 15:22 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (11.98 KB, patch)
2020-04-24 15:23 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (17.51 KB, patch)
2020-04-27 12:51 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2020-04-24 15:22:05 PDT 
OSR Exit compiler should know and print the exiting DFG node's index
Comment 1 Keith Miller 2020-04-24 15:22:28 PDT 
Created attachment 397516 [details]
Patch
Comment 2 Keith Miller 2020-04-24 15:23:50 PDT 
Created attachment 397517 [details]
Patch
Comment 3 Mark Lam 2020-04-24 15:31:02 PDT 
Comment on attachment 397517 [details]
Patch

r=me if you’ve verified that there’s no size increase.
Comment 4 Keith Miller 2020-04-24 16:04:42 PDT 
$ ./Tools/Scripts/dump-class-layout JavaScriptCore DFG::OSRExitBase -c Debug
  +0 < 32> JSC::DFG::OSRExitBase
  +0 <  4>   uint32_t m_count
  +4 <  1>   JSC::ExitKind m_kind
  +5 < :1>   bool m_wasHoisted : 1
  +5 < :23>   uint32_t m_dfgNodeIndex : 23
  +8 <  8>     JSC::CodeOrigin m_codeOrigin
  +8 <  8>       uintptr_t m_compositeValue
 +16 <  8>     JSC::CodeOrigin m_codeOriginForExitProfile
 +16 <  8>       uintptr_t m_compositeValue
 +24 <  4>     JSC::CallSiteIndex m_exceptionHandlerCallSiteIndex
 +24 <  4>       uint32_t m_bits
 +28 <  4>   <PADDING: 4 bytes>
Total byte size: 32
Total pad bytes: 4
Padding percentage: 12.50 %
Comment 5 Keith Miller 2020-04-27 12:51:20 PDT 
Created attachment 397721 [details]
Patch for landing
Comment 6 EWS 2020-04-27 13:22:36 PDT 
Committed r260772: <https://trac.webkit.org/changeset/260772>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397721 [details].
Comment 7 Radar WebKit Bug Importer 2020-04-27 13:23:20 PDT 
<rdar://problem/62465824>
Comment 8 Jason Lawrence 2020-04-27 17:16:56 PDT 
Reverted r260772 for reason:

This commit caused tests to start failing internally.

Committed r260799: <https://trac.webkit.org/changeset/260799>
Comment 9 Keith Miller 2020-04-27 17:51:58 PDT 
Committed r260803: <https://trac.webkit.org/changeset/260803>