Bug 210956 - [JSC] DFG AI for some bitops + BigInt32 should be precise
Summary: [JSC] DFG AI for some bitops + BigInt32 should be precise
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-24 00:56 PDT by Yusuke Suzuki
Modified: 2020-04-24 10:21 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.84 KB, patch)
2020-04-24 00:57 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (3.88 KB, patch)
2020-04-24 01:00 PDT, Yusuke Suzuki 		keith_miller: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-04-24 00:56:25 PDT 
[JSC] DFG AI for some bitops + BigInt32 should be precise
Comment 1 Yusuke Suzuki 2020-04-24 00:57:10 PDT 
Created attachment 397435 [details]
Patch
Comment 2 Yusuke Suzuki 2020-04-24 01:00:47 PDT 
Created attachment 397437 [details]
Patch
Comment 3 Keith Miller 2020-04-24 09:59:47 PDT 
Comment on attachment 397437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397437&action=review

r=me.

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:543
>          // FIXME: this use of binaryUseKind means that we cannot specialize to (for example) a HeapBigInt left-operand and a BigInt32 right-operand.

Can we file a bug for this?
Comment 4 Yusuke Suzuki 2020-04-24 10:15:30 PDT 
Comment on attachment 397437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397437&action=review

Thanks!

>> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:543
>>          // FIXME: this use of binaryUseKind means that we cannot specialize to (for example) a HeapBigInt left-operand and a BigInt32 right-operand.
> 
> Can we file a bug for this?

Added.
Comment 5 Yusuke Suzuki 2020-04-24 10:20:09 PDT 
Committed r260651: <https://trac.webkit.org/changeset/260651>
Comment 6 Radar WebKit Bug Importer 2020-04-24 10:21:17 PDT 
<rdar://problem/62321935>