RESOLVED FIXED 210950
Disable useKernTCSM=false for JSC stress tests to make EWS faster 
https://bugs.webkit.org/show_bug.cgi?id=210950
Summary Disable useKernTCSM=false for JSC stress tests to make EWS faster
Yusuke Suzuki
Reported 2020-04-23 18:03:39 PDT
Disable useKernTCSM=false for JSC stress tests to make EWS faster
Attachments
Patch (1.73 KB, patch)
2020-04-23 18:07 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-04-23 18:07:23 PDT
Created attachment 397410 [details] Patch
Yusuke Suzuki
Comment 2 2020-04-23 18:08:16 PDT
Comment on attachment 397410 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397410&action=review > Tools/Scripts/run-javascriptcore-tests:-532 > -} I'm not sure whether webkitpy's JSC_useKernTCSM also affects on EWS. So I would like to check the environment variables in EWS first.
Yusuke Suzuki
Comment 3 2020-04-23 19:09:59 PDT
EWS JSC stress bot finishes with 59:23, so this patch is effective.
Yusuke Suzuki
Comment 4 2020-04-23 19:10:28 PDT
Comment on attachment 397410 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397410&action=review >> Tools/Scripts/run-javascriptcore-tests:-532 >> -} > > I'm not sure whether webkitpy's JSC_useKernTCSM also affects on EWS. So I would like to check the environment variables in EWS first. I've ensured this works on EWS.
Mark Lam
Comment 5 2020-04-23 20:21:02 PDT
Comment on attachment 397410 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397410&action=review r=me >>> Tools/Scripts/run-javascriptcore-tests:-532 >>> -} >> >> I'm not sure whether webkitpy's JSC_useKernTCSM also affects on EWS. So I would like to check the environment variables in EWS first. > > I've ensured this works on EWS. Jonathan Bedard (cc'ed) added this change. I'm fine with removing it since we have evidence that it speeds up the EWS.
EWS
Comment 6 2020-04-23 20:31:14 PDT
Committed r260617: <https://trac.webkit.org/changeset/260617> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397410 [details].
Radar WebKit Bug Importer
Comment 7 2020-04-23 20:32:14 PDT
<rdar://problem/62278398>
Jonathan Bedard
Comment 8 2020-04-24 06:15:47 PDT
Comment on attachment 397410 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397410&action=review >>>> Tools/Scripts/run-javascriptcore-tests:-532 >>>> -} >>> >>> I'm not sure whether webkitpy's JSC_useKernTCSM also affects on EWS. So I would like to check the environment variables in EWS first. >> >> I've ensured this works on EWS. > > Jonathan Bedard (cc'ed) added this change. I'm fine with removing it since we have evidence that it speeds up the EWS. I would agree. I have evidence JSC_useKernTCSM=false speeds up layout tests, but never had evidence for JSC tests.
Note You need to log in before you can comment on or make changes to this bug.