Bug 210945 - [iOS] Stop using legacy BKSApplicationStateMonitor
Summary: [iOS] Stop using legacy BKSApplicationStateMonitor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 211651
Blocks:
  Show dependency tree / graph
 
Reported: 2020-04-23 17:38 PDT by Chris Dumez
Modified: 2020-05-08 15:59 PDT (History)
4 users (show)

See Also:

Attachments
Patch (11.03 KB, patch)
2020-04-23 17:41 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (11.02 KB, patch)
2020-04-23 17:45 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (11.01 KB, patch)
2020-04-23 17:50 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (11.09 KB, patch)
2020-04-23 17:53 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (11.09 KB, patch)
2020-04-23 17:54 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (11.76 KB, patch)
2020-04-23 18:09 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (11.75 KB, patch)
2020-04-23 18:41 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (11.75 KB, patch)
2020-04-23 19:02 PDT, Chris Dumez 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-04-23 17:38:49 PDT 
Stop using legacy BKSApplicationStateMonitor and use RunningBoard API instead.
Comment 1 Chris Dumez 2020-04-23 17:41:57 PDT 
Created attachment 397404 [details]
Patch
Comment 2 Chris Dumez 2020-04-23 17:45:38 PDT 
Created attachment 397405 [details]
Patch
Comment 3 Chris Dumez 2020-04-23 17:50:35 PDT 
Created attachment 397406 [details]
Patch
Comment 4 Chris Dumez 2020-04-23 17:53:55 PDT 
Created attachment 397407 [details]
Patch
Comment 5 Chris Dumez 2020-04-23 17:54:32 PDT 
Created attachment 397408 [details]
Patch
Comment 6 Chris Dumez 2020-04-23 18:09:27 PDT 
Created attachment 397412 [details]
Patch
Comment 7 Chris Dumez 2020-04-23 18:41:46 PDT 
Created attachment 397414 [details]
Patch
Comment 8 Tim Horton 2020-04-23 18:55:09 PDT 
Comment on attachment 397414 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397414&action=review

> Source/WebKit/Configurations/WebKit.xcconfig:53
> +WK_ASSERTION_SERVICES_LDFLAGS_iphoneos = $(WK_ASSERTION_SERVICES_LDFLAGS_IOS$(WK_IOS_14));
> +WK_ASSERTION_SERVICES_LDFLAGS_iphonesimulator = $(WK_ASSERTION_SERVICES_LDFLAGS_IOS$(WK_IOS_14));

Drop the extra _IOS:

WK_ASSERTION_SERVICES_LDFLAGS_iphoneos = $(WK_ASSERTION_SERVICES_LDFLAGS$(WK_IOS_14));
WK_ASSERTION_SERVICES_LDFLAGS_iphonesimulator = $(WK_ASSERTION_SERVICES_LDFLAGS$(WK_IOS_14));

and you should be good. Sorry for the typo!

> Source/WebKit/Configurations/WebKit.xcconfig:59
> +WK_ASSERTION_SERVICES_LDFLAGS_watchos = -framework AssertionServices;
> +WK_ASSERTION_SERVICES_LDFLAGS_watchsimulator = -framework AssertionServices;
> +WK_ASSERTION_SERVICES_LDFLAGS_appletvos = -framework AssertionServices;
> +WK_ASSERTION_SERVICES_LDFLAGS_appletvsimulator = -framework AssertionServices;

At some point we should get some nice target conditional macros for these too

> Source/WebKit/Configurations/WebKit.xcconfig:60
> +WK_ASSERTION_SERVICES_LDFLAGS_maccatalyst = -framework AssertionServices;

You can totally use WK_MACOS_whatever for macCatalyst
Comment 9 Chris Dumez 2020-04-23 19:02:29 PDT 
Created attachment 397415 [details]
Patch
Comment 10 Tim Horton 2020-04-23 22:32:58 PDT 
Comment on attachment 397415 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397415&action=review

> Source/WebKit/Configurations/WebKit.xcconfig:55
> +// FIXME: It is unecessary to link against AssertionServices with the latest SDK for the following platforms too.

sp: "unecessary"
Comment 11 Chris Dumez 2020-04-24 07:57:38 PDT 
Committed r260642: <https://trac.webkit.org/changeset/260642>
Comment 12 Radar WebKit Bug Importer 2020-04-24 07:58:14 PDT 
<rdar://problem/62312842>