Bug 210941 - unable to build from tot - linux - flatpakutils.py - TypeError: not enough arguments for format string
Summary: unable to build from tot - linux - flatpakutils.py - TypeError: not enough ar...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Linux
: P2 Major
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-23 16:12 PDT by fuzzdragon opensource
Modified: 2020-04-27 02:57 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.48 KB, patch)
2020-04-24 04:32 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description fuzzdragon opensource 2020-04-23 16:12:00 PDT 
unable to build from tot - linux - flatpakutils.py - TypeError: not enough arguments for format string

./Tools/Scripts/build-webkit --gtk
Building flatpak based environment
Traceback (most recent call last):
  File "/yyy/OpenSource/Tools/Scripts/webkit-flatpak", line 28, in <module>
    sys.exit(WebkitFlatpak.load_from_args().run())
  File "/yyy/OpenSource/Tools/flatpak/flatpakutils.py", line 779, in run
    return self.main()
  File "/yyy/OpenSource/Tools/flatpak/flatpakutils.py", line 759, in main
    if not self.clean_args():
  File "/yyy/OpenSource/Tools/flatpak/flatpakutils.py", line 496, in clean_args
    if not check_flatpak():
  File "/yyy/OpenSource/Tools/flatpak/flatpakutils.py", line 134, in check_flatpak
    sys.argv[0])
  File "/yyy/OpenSource/Tools/flatpak/flatpakutils.py", line 113, in error_message
    cls.colored_message_if_supported(Colors.FAIL, str_format, *args)
  File "/yyy/OpenSource/Tools/flatpak/flatpakutils.py", line 102, in colored_message_if_supported
    msg = str_format % args
TypeError: not enough arguments for format string
Comment 1 Philippe Normand 2020-04-24 04:32:07 PDT 
Created attachment 397445 [details]
Patch
Comment 2 Philippe Normand 2020-04-24 04:32:50 PDT 
What is your host linux distro? Did you run Tools/gtk/install-dependencies ?
Comment 3 fuzzdragon opensource 2020-04-24 07:48:23 PDT 

./Tools/gtk/install-dependencies
....

./Tools/Scripts/build-webkit --gtk
Building flatpak based environment

flatpak 1.4.4 required but 1.0.9 found. Please update and try again

I will update this package.

thanks
Comment 4 Philippe Normand 2020-04-24 08:27:50 PDT 
There's still a bug regardless :)
Comment 5 EWS 2020-04-27 02:57:58 PDT 
Committed r260746: <https://trac.webkit.org/changeset/260746>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397445 [details].