Bug 210935 – Resize cursor doesn't show if there's text under the resize control

• Status: RESOLVED
• Resolution: FIXED
• Component: UI Events

[Simon Fraser (smfr)]

Created attachment 397385 [details]
Test

Hover over the resize cursor in the attached testcase. You don't see the resize cursor, instead getting an iBeam.

[Ahmad Saleem]

It seems to be fixed with following Commit:

https://src.chromium.org/viewvc/blink?view=revision&revision=160554

It did changes here:

https://github.com/WebKit/WebKit/blob/9856bc8b756610ac4e3a4a2c480e6332f50e0cd7/Source/WebCore/page/EventHandler.cpp#L1544

___

Webkit (current):

inResizer = layerRenderer.layer()->isPointInResizeControl(roundedIntPoint(result.localPoint()));

Chrome Patch:

inResizer = layer->isPointInResizeControl(result.roundedPointInMainFrame(), ResizerForPointer);

*** Need to be changed ***

inResizer = layerRenderer.layer()->isPointInResizeControl(roundedIntPoint(result.roundedPointInMainFrame(), localPoint);

___

If someone can confirm the approach, I am happy to do PR. Only problem / build error might be that it could only accept 1 argument but now we are providing it two. For that, if we can do:

auto joined = roundedIntPoint(result.roundedPointInMainFrame(), localPoint);

and then pass on single argument.

[Ahmad Saleem]

To this:

inResizer = layerRenderer.layer()->isPointInResizeControl(result.roundedPointInMainFrame(), localPoint);

[Alexsander Borges Damaceno]

Pull request: https://github.com/WebKit/WebKit/pull/45131

[EWS]

Committed 294907@main (342a27a71e7c): <https://commits.webkit.org/294907@main>

Reviewed commits have been landed. Closing PR #45131 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/151309503>