JS tests should only spew things onto my screen if they succeed. ensure-crash appears to succeed but spews errors onto my screen. We should either skip it so it doesn't pollute a user's screen with errors that aren't errors or we should make it so that `crash!` or whatever makes the test not spew things unless it fails. run-jsc-stress-tests has the ability to log output and then only spew it if there was an actual error. We should use that.
(In reply to Filip Pizlo from comment #0) > JS tests should only spew things onto my screen if they succeed. I mean if they fail. > > ensure-crash appears to succeed but spews errors onto my screen. > > We should either skip it so it doesn't pollute a user's screen with errors > that aren't errors or we should make it so that `crash!` or whatever makes > the test not spew things unless it fails. run-jsc-stress-tests has the > ability to log output and then only spew it if there was an actual error. > We should use that.
Created attachment 397418 [details] Patch
Created attachment 397419 [details] Patch
Committed r260620: <https://trac.webkit.org/changeset/260620> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397419 [details].
<rdar://problem/62281561>