...
Created attachment 397514 [details] patch
Created attachment 397523 [details] patch
Comment on attachment 397523 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=397523&action=review r=me > Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:555 > + } else if (node->binaryUseKind() == HeapBigIntUse) { Use `node->isBinaryUseKind(HeapBigIntUse)`. > Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:560 > + } else if (node->binaryUseKind() == AnyBigIntUse) Ditto. > Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:750 > + if (node->binaryUseKind() == HeapBigIntUse) { Use `node->isBinaryUseKind(HeapBigIntUse)`. > Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:755 > + } else if (node->binaryUseKind() == AnyBigIntUse || node->binaryUseKind() == BigInt32Use) Use `node->isBinaryUseKind(AnyBigIntUse) || node->isBinaryUseKind(BigInt32Use)`. > Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1024 > + if (node->binaryUseKind() == HeapBigIntUse) { Use `node->isBinaryUseKind(HeapBigIntUse)`. > Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1029 > + } else if (node->binaryUseKind() == AnyBigIntUse || node->binaryUseKind() == BigInt32Use) Ditto. > Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1040 > + if (node->binaryUseKind() == HeapBigIntUse) { Ditto. > Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1045 > + } else if (node->binaryUseKind() == AnyBigIntUse || node->binaryUseKind() == BigInt32Use) Ditto. > Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1109 > + if (node->binaryUseKind() == HeapBigIntUse) { Ditto. > Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1114 > + } else if (node->binaryUseKind() == AnyBigIntUse || node->binaryUseKind() == BigInt32Use) Ditto. > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:3748 > + if (node->binaryUseKind() == HeapBigIntUse) { `node->isBinaryUseKind(HeapBigIntUse)` would be better. > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Just remove it. This is already covered by existing tests.
landed in: https://trac.webkit.org/changeset/260683/webkit
<rdar://problem/62351393>