Bug 210916 – Regression after r260359 ([GTK][WPE] lowWatermarkPages() in MemoryPressureMonitor.cpp only searches the "low" value inside the first "Node" section)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Pablo Saavedra]

Changes in https://bugs.webkit.org/show_bug.cgi?id=210345 leaks file descriptors:


```
This change is leaking file handles. I see constant additions of the triple:

  /proc/meminfo
  /proc/zoneinfo
  /proc/18738/cgroup

in `lsof -p PID`. It lasts up to the top opened files limit is reached.

You should, in MemoryPressureMonitor::start(), fclose() those which had been opened, both in the 'continue' and in the end of the while() (not only after it, which handles the 'break' path).
```

Ref: https://bugs.webkit.org/show_bug.cgi?id=210345#c5

[Adrian Perez]

Created attachment 397355 [details]
Patch

[Carlos Alberto Lopez Perez]

Comment on attachment 397355 [details]
Patch

interesting patch, looks good... but there are some build errors on the EWS.

[Adrian Perez]

Created attachment 397373 [details]
Patch v2

[Adrian Perez]

(In reply to Carlos Alberto Lopez Perez from comment #2)
> Comment on attachment 397355 [details]
> Patch
> 
> interesting patch, looks good... but there are some build errors on the EWS.

Yes, I forgot to add one bit before uploading, it should be fixed now.

[Carlos Alberto Lopez Perez]

Comment on attachment 397373 [details]
Patch v2

r=me
Looks nice! thanks

[EWS]

Committed r260592: <https://trac.webkit.org/changeset/260592>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397373 [details].

[Milan Crha]

> precise if thy are eventually

s/thy/they/

From the working point of view: seems to work properly. Thanks.