RESOLVED FIXED 210914
Correction for patch 397001.
https://bugs.webkit.org/show_bug.cgi?id=210914
Summary Correction for patch 397001.
Andres Gonzalez
Reported 2020-04-23 08:26:12 PDT
Correction for patch 397001.
Attachments
Patch (3.92 KB, patch)
2020-04-23 08:35 PDT, Andres Gonzalez
no flags
Andres Gonzalez
Comment 1 2020-04-23 08:35:01 PDT
EWS
Comment 2 2020-04-23 09:12:09 PDT
Committed r260573: <https://trac.webkit.org/changeset/260573> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397344 [details].
Radar WebKit Bug Importer
Comment 3 2020-04-23 09:13:16 PDT
Darin Adler
Comment 4 2020-04-23 10:47:58 PDT
Comment on attachment 397344 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397344&action=review > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2289 > + AXTRACE(String("WebAccessibilityObjectWrapper accessibilityAttributeValue:") + String(attributeName)); makeString is more efficient than making two String objects and then calling +; allocates 1 String instead 3 > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3872 > + AXTRACE(String("WebAccessibilityObjectWrapper accessibilityAttributeValue:") + String(attribute)); Ditto. > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:4477 > + AXTRACE(String("WebAccessibilityObjectWrapper accessibilityArrayAttributeValue:") + String(attribute)); Ditto.
Note You need to log in before you can comment on or make changes to this bug.