Bug 210914 - Correction for patch 397001.
Summary: Correction for patch 397001.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-23 08:26 PDT by Andres Gonzalez
Modified: 2020-04-23 10:47 PDT (History)
10 users (show)

See Also:

Attachments
Patch (3.92 KB, patch)
2020-04-23 08:35 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-04-23 08:26:12 PDT 
Correction for patch 397001.
Comment 1 Andres Gonzalez 2020-04-23 08:35:01 PDT 
Created attachment 397344 [details]
Patch
Comment 2 EWS 2020-04-23 09:12:09 PDT 
Committed r260573: <https://trac.webkit.org/changeset/260573>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397344 [details].
Comment 3 Radar WebKit Bug Importer 2020-04-23 09:13:16 PDT 
<rdar://problem/62248776>
Comment 4 Darin Adler 2020-04-23 10:47:58 PDT 
Comment on attachment 397344 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397344&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2289
> +    AXTRACE(String("WebAccessibilityObjectWrapper accessibilityAttributeValue:") + String(attributeName));

makeString is more efficient than making two String objects and then calling +; allocates 1 String instead 3

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3872
> +    AXTRACE(String("WebAccessibilityObjectWrapper accessibilityAttributeValue:") + String(attribute));

Ditto.

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:4477
> +    AXTRACE(String("WebAccessibilityObjectWrapper accessibilityArrayAttributeValue:") + String(attribute));

Ditto.