Bug 210890 - Web Inspector: Uncaught Exception: SyntaxError: Invalid regular expression: missing )
Summary: Web Inspector: Uncaught Exception: SyntaxError: Invalid regular expression: m...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL: https://webkit.org/
Keywords: InRadar
Depends on:
Reported: 2020-04-22 18:24 PDT by Devin Rousso
Modified: 2020-04-23 12:50 PDT (History)
4 users (show)

See Also:

Patch (32.26 KB, patch)
2020-04-22 20:02 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-04-22 18:24:06 PDT
Uncaught Exception in Web Inspector.

1. inspect any page
2. enable Search: Regular Expression in the General pane of the Settings Tab
3. go to the Sources Tab
4. enter "asd(" in the filter bar at the bottom of the navigation sidebar

Uncaught Exceptions:
 - SyntaxError: Invalid regular expression: missing ) (at SearchUtilities.js:113:26)
    RegExp @ [native code]
    _regExpForString @ SearchUtilities.js:113:26
    updateFilter @ NavigationSidebarPanel.js:320:88
    _filterDidChange @ NavigationSidebarPanel.js:579:26
    dispatch @ Object.js:165:30
    dispatchEventToListeners @ Object.js:172:17
    _handleFilterChanged @ FilterBar.js:183:42
    _handleFilterChanged @ [native code]

Inspected URL:        https://webkit.org/
Loading completed:    true
Frontend User Agent:  Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/605.1.15 (KHTML, like Gecko)
Comment 1 Devin Rousso 2020-04-22 20:02:20 PDT
Created attachment 397307 [details]
Comment 2 BJ Burg 2020-04-23 12:33:51 PDT
Comment on attachment 397307 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=397307&action=review


> Source/WebInspectorUI/ChangeLog:52
> +        * UserInterface/Views/SearchBar.css: Removed.


> Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js:463
> +        let filterBar = this._filterBarNavigationItem.filterBar;

Thank you for de-indenting this function.
Comment 3 EWS 2020-04-23 12:49:05 PDT
Committed r260589: <https://trac.webkit.org/changeset/260589>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397307 [details].
Comment 4 Radar WebKit Bug Importer 2020-04-23 12:50:33 PDT