Bug 210890 – Web Inspector: Uncaught Exception: SyntaxError: Invalid regular expression: missing )

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

Uncaught Exception in Web Inspector.

# STEPS TO REPRODUCE
1. inspect any page
2. enable Search: Regular Expression in the General pane of the Settings Tab
3. go to the Sources Tab
4. enter "asd(" in the filter bar at the bottom of the navigation sidebar

Uncaught Exceptions:
-----------------------
 - SyntaxError: Invalid regular expression: missing ) (at SearchUtilities.js:113:26)
    RegExp @ [native code]
    _regExpForString @ SearchUtilities.js:113:26
    updateFilter @ NavigationSidebarPanel.js:320:88
    _filterDidChange @ NavigationSidebarPanel.js:579:26
    dispatch @ Object.js:165:30
    dispatchEventToListeners @ Object.js:172:17
    _handleFilterChanged @ FilterBar.js:183:42
    _handleFilterChanged @ [native code]
-----------------------

Notes:
Inspected URL:        https://webkit.org/
Loading completed:    true
Frontend User Agent:  Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/605.1.15 (KHTML, like Gecko)

[Devin Rousso]

Created attachment 397307 [details]
Patch

[Blaze Burg]

Comment on attachment 397307 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397307&action=review

r=me

> Source/WebInspectorUI/ChangeLog:52
> +        * UserInterface/Views/SearchBar.css: Removed.

o_O

> Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js:463
> +        let filterBar = this._filterBarNavigationItem.filterBar;

Thank you for de-indenting this function.

[EWS]

Committed r260589: <https://trac.webkit.org/changeset/260589>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397307 [details].

[Radar WebKit Bug Importer]

<rdar://problem/62258087>