Bug 21089 - Avoid constantly branching on m_table in getOffset
Summary: Avoid constantly branching on m_table in getOffset
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-24 22:48 PDT by Maciej Stachowiak
Modified: 2012-09-07 00:29 PDT (History)
1 user (show)

See Also:

Attachments
patch for testing - does what I said, not sure if it is a speedup (8.66 KB, patch)
2008-09-24 22:49 PDT, Maciej Stachowiak 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2008-09-24 22:48:26 PDT 
Profiles show that getOwnPropertySlot/getOffset spends a lot of time on the initial branch in getOFfset that checks if the table is null. Now that PropertyMap no longer has to fit into a cell, it could keep a table up to a certain limit inline and avoid this null check.
Comment 1 Maciej Stachowiak 2008-09-24 22:49:43 PDT 
Created attachment 23779 [details]
patch for testing - does what I said, not sure if it is a speedup
Comment 2 Gavin Barraclough 2012-09-07 00:29:30 PDT 
This patch will not apply to ToT.