Bug 210874 - All ITP database tables should reference the ObservedDomains table on DELETE CASCADE
Summary: All ITP database tables should reference the ObservedDomains table on DELETE ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: katherine_cheney
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-22 14:08 PDT by katherine_cheney
Modified: 2020-04-23 13:17 PDT (History)
4 users (show)

See Also:


Attachments
Patch (12.77 KB, patch)
2020-04-22 14:21 PDT, katherine_cheney
no flags Details | Formatted Diff | Diff
Patch (25.17 KB, patch)
2020-04-22 17:25 PDT, katherine_cheney
no flags Details | Formatted Diff | Diff
Patch (25.14 KB, patch)
2020-04-23 09:31 PDT, katherine_cheney
no flags Details | Formatted Diff | Diff
Patch (27.72 KB, patch)
2020-04-23 12:48 PDT, katherine_cheney
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description katherine_cheney 2020-04-22 14:08:17 PDT
This will make deleting individual ITP entries from the database very simple.
Comment 1 Radar WebKit Bug Importer 2020-04-22 14:08:43 PDT
<rdar://problem/62209438>
Comment 2 katherine_cheney 2020-04-22 14:21:22 PDT
Created attachment 397260 [details]
Patch
Comment 3 katherine_cheney 2020-04-22 17:25:18 PDT
Created attachment 397295 [details]
Patch
Comment 4 katherine_cheney 2020-04-22 17:25:26 PDT
+ test case
Comment 5 Brady Eidson 2020-04-22 19:47:07 PDT
Comment on attachment 397295 [details]
Patch

This seems reasonable, but every bot is sad.
Comment 6 katherine_cheney 2020-04-23 08:16:53 PDT
(In reply to Brady Eidson from comment #5)
> Comment on attachment 397295 [details]
> Patch
> 
> This seems reasonable, but every bot is sad.

Hopefully just needs a rebase
Comment 7 katherine_cheney 2020-04-23 09:31:26 PDT
Created attachment 397348 [details]
Patch
Comment 8 katherine_cheney 2020-04-23 12:48:11 PDT
Created attachment 397376 [details]
Patch
Comment 9 katherine_cheney 2020-04-23 12:49:36 PDT
Realized this should call createUniqueIndices() again after creating the new schema (they get deleted when migrating the data). Added this and updated the test case to check for it.
Comment 10 EWS 2020-04-23 13:17:53 PDT
Committed r260594: <https://trac.webkit.org/changeset/260594>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397376 [details].