Bug 210860 – [JSC] JSBigInt inc operation does not produce right HeapBigInt zero

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Yusuke Suzuki]

I've crafted the custom build of JSC, and found this.
Looking.

[Yusuke Suzuki]

--useJIT=0 fails. This is C++ runtime bug.

[Yusuke Suzuki]

(In reply to Yusuke Suzuki from comment #1)
> --useJIT=0 fails. This is C++ runtime bug.

Or LLInt.

[Yusuke Suzuki]

Created attachment 397204 [details]
Patch

[Mark Lam]

Comment on attachment 397204 [details]
Patch

r=me

[Robin Morisset]

Comment on attachment 397204 [details]
Patch

good catch. r=me as well.

[Yusuke Suzuki]

EWS gets green (failures are known ones). Landing.

[Yusuke Suzuki]

Committed r260522: <https://trac.webkit.org/changeset/260522>

[Radar WebKit Bug Importer]

<rdar://problem/62197537>

[Saam Barati]

Comment on attachment 397204 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397204&action=review

> Source/JavaScriptCore/runtime/JSCJSValue.cpp:315
> +            out.print("BigInt[heap-allocated]: addr=", RawPointer(asCell()), ", length=", jsCast<JSBigInt*>(asCell())->length(), ", sign=", jsCast<JSBigInt*>(asCell())->sign());

nice. Maybe we could also just toString this?

[Yusuke Suzuki]

Comment on attachment 397204 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397204&action=review

>> Source/JavaScriptCore/runtime/JSCJSValue.cpp:315
>> +            out.print("BigInt[heap-allocated]: addr=", RawPointer(asCell()), ", length=", jsCast<JSBigInt*>(asCell())->length(), ", sign=", jsCast<JSBigInt*>(asCell())->sign());
> 
> nice. Maybe we could also just toString this?

Sounds good. Let's extend it!