Bug 210858 – getDisplayMedia is not respecting aspect ratio with max constraints

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

getDisplayMedia is not respecting aspect ratio with max constraints

[youenn fablet]

Created attachment 397209 [details]
Patch

[youenn fablet]

<rdar://problem/61405434>

[youenn fablet]

Created attachment 397210 [details]
Patch

[youenn fablet]

Created attachment 397214 [details]
Patch

[youenn fablet]

Created attachment 397215 [details]
Patch

[youenn fablet]

Created attachment 397221 [details]
Patch

[Eric Carlson]

Comment on attachment 397221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397221&action=review

> Source/WebCore/platform/mediastream/mac/ScreenDisplayCapturerMac.mm:56
> +        RELEASE_LOG(Media, "CGGetActiveDisplayList() returned error %d when trying to get display count", static_cast<int>(err));

This isn't new, but other logging uses the WebRTC channel. If you made this a member function it could use ERROR_LOG_IF.

> Source/WebCore/platform/mediastream/mac/ScreenDisplayCapturerMac.mm:203
> +    return DisplayCaptureSourceCocoa::DisplayFrameType { RetainPtr<IOSurfaceRef> { m_currentFrame.ioSurface() } };

This isn't new, but shouldn't we have a lock around access to m_currentFrame since it is changed on another thread?

[youenn fablet]

Created attachment 397237 [details]
Patch

[youenn fablet]

Created attachment 397325 [details]
Patch for landing

[EWS]

Committed r260561: <https://trac.webkit.org/changeset/260561>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397325 [details].

[Aakash Jain]

Newly added layout test fast/mediastream/getDisplayMedia-max-constraints.html seems to be failing consistently and slowing down ios-wk2 EWS. This issue was also indicated by red ios-wk2 ews bubble.

[youenn fablet]

(In reply to Aakash Jain from comment #11)
> Newly added layout test
> fast/mediastream/getDisplayMedia-max-constraints.html seems to be failing
> consistently and slowing down ios-wk2 EWS. This issue was also indicated by
> red ios-wk2 ews bubble.

They should have been skipped on iOS

[youenn fablet]

Reopening to attach new patch.

[youenn fablet]

Created attachment 397434 [details]
Patch

[EWS]

Committed r260638: <https://trac.webkit.org/changeset/260638>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397434 [details].