So that layout tests can run in a gst-build uninstalled environment.
Created attachment 397186 [details]
Comment on attachment 397186 [details]
Related comment, but not for addressing in this patch: It would be neat if we
could unify the list of whitelisted environment variables for both the GTK and
WPE ports, keep them in a list, then iterate over it in common code instead of
repeating a bunch of calls to “_copy_value_from_environ_if_set()” 🤔️
Yeah I agree. I'm not sure why this was duplicated in the first place.
Committed r260562: <https://trac.webkit.org/changeset/260562>
Re-opened since this is blocked by bug 210924
Created attachment 397442 [details]
api-gtk green whoohoooo
So the issue was because GST_PLUGIN_PATH_1_0 missing?
BTW, maybe you also want to add REGISTRY_1_0 to the list. My WebKit internal JHBuild defines this:
$ Tools/jhbuild/jhbuild-wrapper --gtk run env|grep GST
(In reply to Carlos Alberto Lopez Perez from comment #10)
> So the issue was because GST_PLUGIN_PATH_1_0 missing?
> BTW, maybe you also want to add REGISTRY_1_0 to the list. My WebKit internal
> JHBuild defines this:
> $ Tools/jhbuild/jhbuild-wrapper --gtk run env|grep GST
Well, I don't think so. Seems like some unmaintained jhbuild stuff to me :) Here gstreamer-1.0.registry doesn't exist and gstreamer-0.10.registry is actually the registry for 1.x... :P
Committed r260641: <https://trac.webkit.org/changeset/260641>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 397442 [details].