Bug 21084 - Make concept of children cross-platform on ScrollView
Summary: Make concept of children cross-platform on ScrollView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 21083
  Show dependency tree / graph
 
Reported: 2008-09-24 17:23 PDT by Dave Hyatt
Modified: 2008-09-25 00:39 PDT (History)
0 users

See Also:

Attachments
Patch (19.57 KB, patch)
2008-09-24 23:56 PDT, Dave Hyatt 		no flags Details | Formatted Diff | Diff
patch #2 (22.02 KB, patch)
2008-09-25 00:01 PDT, Dave Hyatt 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2008-09-24 17:23:34 PDT 
Move the m_children member and children() accessors to FrameView, along with any methods of ScrollView that need to access children.
Comment 1 Dave Hyatt 2008-09-24 23:56:39 PDT 
Created attachment 23782 [details]
Patch
Comment 2 Dave Hyatt 2008-09-25 00:01:52 PDT 
Created attachment 23783 [details]
patch #2
Comment 3 Sam Weinig 2008-09-25 00:07:57 PDT 
Comment on attachment 23783 [details]
patch #2

>+        Reviewed by NOBODY (OOPS!).

I AM A SOMEBODY!

>+        const HashSet<Widget*>* children() const { return &m_children; }

Ick,  But I guess this has been here a while.

>-        void removeChild(Widget*);
>-
>+        

Whitespace added.


Looks good.  I think the implementations of addChildPlatformWidget and removeChildPlatformWidget should assert that the widget is a platform widget, just to be safe.  

r=me
Comment 4 Dave Hyatt 2008-09-25 00:39:38 PDT 
Fixed in r36886.