Bug 210838 - Web Inspector: REGRESSION(r255396): Graphics: viewing a shader program hides the navigation sidebar
Summary: Web Inspector: REGRESSION(r255396): Graphics: viewing a shader program hides ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 205434
Blocks:
  Show dependency treegraph
 
Reported: 2020-04-21 18:54 PDT by Devin Rousso
Modified: 2020-04-21 21:28 PDT (History)
5 users (show)

See Also:


Attachments
Patch (6.15 KB, patch)
2020-04-21 19:11 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-04-21 18:54:20 PDT
# STEPS TO REPRODUCE
1. inspect any page with a WebGL/WebGPU <canvas>
2. go to the Graphics Tab
3. select the WebGL context or WebGPU device
4. select a shader program in the navigations sidebar
 => the shader's contents are shown and the navigation sidebar collapses
Comment 1 Devin Rousso 2020-04-21 19:11:25 PDT
Created attachment 397159 [details]
Patch
Comment 2 Joseph Pecoraro 2020-04-21 20:35:20 PDT
Comment on attachment 397159 [details]
Patch

r=me
Comment 3 BJ Burg 2020-04-21 21:10:13 PDT
Comment on attachment 397159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397159&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/Main.js:1404
> +        || representedObject instanceof WI.AnimationCollection

Thank you for newlines.
Comment 4 EWS 2020-04-21 21:27:33 PDT
Committed r260502: <https://trac.webkit.org/changeset/260502>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397159 [details].
Comment 5 Radar WebKit Bug Importer 2020-04-21 21:28:15 PDT
<rdar://problem/62153943>