Bug 210832 - [JSC] SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq should expect AnyBigIntUse
Summary: [JSC] SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq should expect AnyBigI...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-21 17:35 PDT by Yusuke Suzuki
Modified: 2020-04-21 21:20 PDT (History)
7 users (show)

See Also:


Attachments
Patch (13.43 KB, patch)
2020-04-21 17:42 PDT, Yusuke Suzuki
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-04-21 17:35:13 PDT
[JSC] SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq should expect AnyBigIntUse
Comment 1 Yusuke Suzuki 2020-04-21 17:42:26 PDT
Created attachment 397151 [details]
Patch
Comment 2 Mark Lam 2020-04-21 19:13:51 PDT
Comment on attachment 397151 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397151&action=review

r=me

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:422
>  void SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq(Node* node, bool invert)

Since we may now need to speculate for AnyBigIntUse, the name nonSpeculativeNonPeepholeStrictEq (and its caller nonSpeculativeStrictEq) is now inaccurate.  I suggest changing them to genericNonPeepholeStrictEq and genericStrictEq respectively.  "Generic" here being the generic JSValue case.  Or perhaps genericJSValueNonPeepholeStrictEq and genericJSValueStrictEq?
Comment 3 Yusuke Suzuki 2020-04-21 19:17:27 PDT
Comment on attachment 397151 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397151&action=review

>> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:422
>>  void SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq(Node* node, bool invert)
> 
> Since we may now need to speculate for AnyBigIntUse, the name nonSpeculativeNonPeepholeStrictEq (and its caller nonSpeculativeStrictEq) is now inaccurate.  I suggest changing them to genericNonPeepholeStrictEq and genericStrictEq respectively.  "Generic" here being the generic JSValue case.  Or perhaps genericJSValueNonPeepholeStrictEq and genericJSValueStrictEq?

Nice catch! We should use genericJSValueNonPeepholeStrictEq / genericJSValueStrictEq. Fixed.
Comment 4 Yusuke Suzuki 2020-04-21 19:48:31 PDT
Run JSC tests locally.
Comment 5 Yusuke Suzuki 2020-04-21 19:54:34 PDT
Committed r260490: <https://trac.webkit.org/changeset/260490>
Comment 6 Radar WebKit Bug Importer 2020-04-21 19:55:15 PDT
<rdar://problem/62149170>
Comment 7 Yusuke Suzuki 2020-04-21 21:20:00 PDT
Committed r260501: <https://trac.webkit.org/changeset/260501>