Bug 210821 - makeValueRefForValue should be robust against the type encoding of a NSNumber backed by a boolean
Summary: makeValueRefForValue should be robust against the type encoding of a NSNumber...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-21 16:04 PDT by Saam Barati
Modified: 2020-04-23 16:01 PDT (History)
6 users (show)

See Also:


Attachments
patch (1.45 KB, patch)
2020-04-21 16:09 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-04-21 16:04:09 PDT
...
Comment 1 Radar WebKit Bug Importer 2020-04-21 16:04:18 PDT
<rdar://problem/62136598>
Comment 2 Saam Barati 2020-04-21 16:09:40 PDT
Created attachment 397136 [details]
patch
Comment 3 EWS 2020-04-22 09:22:43 PDT
Committed r260515: <https://trac.webkit.org/changeset/260515>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397136 [details].
Comment 4 Darin Adler 2020-04-23 16:01:33 PDT
Comment on attachment 397136 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397136&action=review

> Tools/ChangeLog:5
> +        makeValueRefForValue should be robust against the type encoding of a NSNumber backed by a boolean
> +        https://bugs.webkit.org/show_bug.cgi?id=210821
> +        <rdar://problem/62136598>

Does anything like this affect JavaScript’s Objective-C API, beyond our testing tool?