Bug 210819 - [Cocoa] Don't bother compiling UpdateInfo since it's not used
Summary: [Cocoa] Don't bother compiling UpdateInfo since it's not used
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
Keywords: InRadar
Depends on:
Reported: 2020-04-21 15:41 PDT by Brent Fulgham
Modified: 2020-04-21 16:20 PDT (History)
5 users (show)

See Also:

Patch (2.89 KB, patch)
2020-04-21 15:43 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2020-04-21 15:41:35 PDT
We don't use the UpdateInfo class in Cocoa-based builds, so let's not bother building it!
Comment 1 Brent Fulgham 2020-04-21 15:43:28 PDT
Created attachment 397132 [details]
Comment 2 Darin Adler 2020-04-21 15:46:17 PDT
Comment on attachment 397132 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=397132&action=review

> Source/WebKit/UIProcess/DrawingAreaProxy.h:55
> +class UpdateInfo;
> +#endif

Seems overkill to make the forward declaration conditional. OK, but maybe not necessary to be so careful.
Comment 3 EWS 2020-04-21 16:12:33 PDT
Committed r260473: <https://trac.webkit.org/changeset/260473>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397132 [details].
Comment 4 Radar WebKit Bug Importer 2020-04-21 16:13:15 PDT
Comment 5 Brent Fulgham 2020-04-21 16:20:12 PDT
This was actually <rdar://problem/61774766>.