Bug 210817 - [Web Animations] Add a supporting object for Document to manage timelines
Summary: [Web Animations] Add a supporting object for Document to manage timelines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-21 14:51 PDT by Antoine Quint
Modified: 2020-04-22 00:17 PDT (History)
7 users (show)

See Also:

Attachments
Patch (19.70 KB, patch)
2020-04-21 14:54 PDT, Antoine Quint 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2020-04-21 14:51:14 PDT 
[Web Animations] Add a supporting object for Document to manage timelines
Comment 1 Antoine Quint 2020-04-21 14:54:21 PDT 
Created attachment 397127 [details]
Patch
Comment 2 Dean Jackson 2020-04-21 15:11:33 PDT 
Comment on attachment 397127 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397127&action=review

> Source/WebCore/animation/DocumentTimelinesController.cpp:65
> +        if (!shouldUpdateAnimations && timeline.scheduledUpdate())

Is it expensive to call scheduledUpdate()? if not, skip the !shouldUpdateAnimations

> Source/WebCore/animation/DocumentTimelinesController.cpp:67
> +        timelines.append(&timeline);

We don't have a filter method?
Comment 3 Antoine Quint 2020-04-22 00:10:41 PDT 
(In reply to Dean Jackson from comment #2)
> Comment on attachment 397127 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=397127&action=review
> 
> > Source/WebCore/animation/DocumentTimelinesController.cpp:65
> > +        if (!shouldUpdateAnimations && timeline.scheduledUpdate())
> 
> Is it expensive to call scheduledUpdate()? if not, skip the
> !shouldUpdateAnimations

Sure.

> > Source/WebCore/animation/DocumentTimelinesController.cpp:67
> > +        timelines.append(&timeline);
> 
> We don't have a filter method?

We don't filter :)
Comment 4 Antoine Quint 2020-04-22 00:17:01 PDT 
Committed r260504: <https://trac.webkit.org/changeset/260504>
Comment 5 Radar WebKit Bug Importer 2020-04-22 00:17:16 PDT 
<rdar://problem/62162278>