Bug 210811 – Move WebKit.WebViewCategory test to InAppBrowserPrivacy.mm

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Kate Cheney]

This test was added before InAppBrowserPrivacy.mm existed. It should be moved here so it has access to all setup/cleanup needed by these tests

[Kate Cheney]

<rdar://problem/60972505>

[Kate Cheney]

Created attachment 397104 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 397104 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397104&action=review

rs=me

> Tools/TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:-65
> -    auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
> -    EXPECT_EQ([configuration _webViewCategory], _WKWebViewCategoryAppBoundDomain);

Can you add an explanation to ChangeLog about why this failed? Naively, I would expect the state of an object that was just init'ed to always the the same, and not require "initializeInAppBrowserPrivacyTestSettings()".

> Tools/TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:-71
> -    [configuration _setWebViewCategory:_WKWebViewCategoryInAppBrowser];
> -    EXPECT_EQ([configuration _webViewCategory], _WKWebViewCategoryInAppBrowser);
> -
> -    [configuration _setWebViewCategory:_WKWebViewCategoryWebBrowser];
> -    EXPECT_EQ([configuration _webViewCategory], _WKWebViewCategoryWebBrowser);

Seems OK to move everything, but it may be even better to keep tests for other categories here.

[EWS]

Committed r260451: <https://trac.webkit.org/changeset/260451>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397104 [details].