Bug 210810 – [Mac] Enable color well tests on Modern WebKit

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Darin Adler]

[Mac] Enable color well tests on Modern WebKit

[Darin Adler]

Created attachment 397101 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 397101 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397101&action=review

> LayoutTests/platform/mac-wk1/TestExpectations:189
> +# Color Well is turned off

I know that this is a copied comment, but it still lacks a period.

> LayoutTests/platform/mac/TestExpectations:1581
> +# Originally skipped because color well was turned off. Now it's on for Modern WebKit on Mac; should figure out how to re-enable these for that case.
>  editing/pasteboard/drag-and-drop-color-input.html [ Skip ]
>  editing/pasteboard/drag-and-drop-color-input-events.html [ Skip ]

It may be better to duplicate these in mac-wk1 and mac-wk2, with mac-wk2 copy under the "[WK2] [Mac] Support drag in mouse events for WebKit2 EventSender" section.

[Darin Adler]

Created attachment 397125 [details]
Patch

[Darin Adler]

New version incorporates your comments, Alexey, and also deletes some obsolete directories I stumbled on.

[Darin Adler]

Alexey, ideally I’d like your informal "thumbs up" before I land this.

[Alexey Proskuryakov]

Comment on attachment 397125 [details]
Patch

mac-highsierra is hardcoded in some webkitpy tests (which didn't get triggered on EWS), and I don't know if any of those access the actual file system. So there is some risk, and it would be ideal to land these changes separately.

But we can do a followup fix later in the unlikely case that it causes test failures.

[Jonathan Bedard]

(In reply to Alexey Proskuryakov from comment #6)
> Comment on attachment 397125 [details]
> Patch
> 
> mac-highsierra is hardcoded in some webkitpy tests (which didn't get
> triggered on EWS), and I don't know if any of those access the actual file
> system. So there is some risk, and it would be ideal to land these changes
> separately.
> 
> But we can do a followup fix later in the unlikely case that it causes test
> failures.

There are some webkitpy tests that access the real file system, but the ones that hard-code High Sierra do it to test port construction, if I recall, and are unrelated to test expectations.

In any case, changes made to support iPad mean that expectation parsing should work fine if one of the directories in your baseline search path is missing.

[EWS]

Committed r260471: <https://trac.webkit.org/changeset/260471>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397125 [details].

[Radar WebKit Bug Importer]

<rdar://problem/62136404>