Bug 210809 - Fix for remoteParentObject and platformWidget not being stored properly in the AXIsolatedObject attributes variant.
Summary: Fix for remoteParentObject and platformWidget not being stored properly in th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-21 11:43 PDT by Andres Gonzalez
Modified: 2020-04-21 13:22 PDT (History)
9 users (show)

See Also:

Attachments
Patch (7.86 KB, patch)
2020-04-21 11:49 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-04-21 11:43:58 PDT 
Fix for remoteParentObject and platformWidget not being stored properly in the AXIsolatedObject attributes variant.
Comment 1 Andres Gonzalez 2020-04-21 11:49:48 PDT 
Created attachment 397100 [details]
Patch
Comment 2 chris fleizach 2020-04-21 11:52:10 PDT 
Comment on attachment 397100 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397100&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:908
> +    PlatformWidget m_platformWidget;

Is PlatformWidget typedef to RetainPtr<NSView> already? can we move that out of the #if and share the same line?
Comment 3 Andres Gonzalez 2020-04-21 12:05:33 PDT 
(In reply to chris fleizach from comment #2)
> Comment on attachment 397100 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=397100&action=review
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:908
> > +    PlatformWidget m_platformWidget;
> 
> Is PlatformWidget typedef to RetainPtr<NSView> already? can we move that out
> of the #if and share the same line?

It is a HWND on Windows and a void* on GTK. Since this is not implemented in any other platform, I could remove the declaration from the other platforms, but thought that it might be a hint for future implementations.
Comment 4 EWS 2020-04-21 13:21:09 PDT 
Committed r260448: <https://trac.webkit.org/changeset/260448>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397100 [details].
Comment 5 Radar WebKit Bug Importer 2020-04-21 13:22:16 PDT 
<rdar://problem/62127479>