Bug 210808 – [iOS] Provide better names for ProcessThrottler process assertions

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Provide better names for ProcessThrottler process assertions, to facilitate debugging.

[Chris Dumez]

Created attachment 397097 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/62121697>

[Sam Weinig]

Comment on attachment 397097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397097&action=review

> Source/WebKit/UIProcess/ProcessThrottler.cpp:105
> +    String typeString;

ASCIILiteral?

> Source/WebKit/UIProcess/ProcessThrottler.cpp:115
> +    case ProcessAssertionType::Foreground:
> +        typeString = "Foreground";
> +        break;
> +    case ProcessAssertionType::Background:
> +        typeString = "Background";
> +        break;
> +    case ProcessAssertionType::Suspended:
> +        typeString = "Suspended";
> +        break;

Why only these three?

[Chris Dumez]

Comment on attachment 397097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397097&action=review

>> Source/WebKit/UIProcess/ProcessThrottler.cpp:105
>> +    String typeString;
> 
> ASCIILiteral?

Ok.

>> Source/WebKit/UIProcess/ProcessThrottler.cpp:115
>> +        break;
> 
> Why only these three?

Yes, we only use these 3 in the ProcessThrottler.

[Chris Dumez]

Comment on attachment 397097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397097&action=review

>>> Source/WebKit/UIProcess/ProcessThrottler.cpp:115
>>> +        break;
>> 
>> Why only these three?
> 
> Yes, we only use these 3 in the ProcessThrottler.

See ProcessThrottler::expectedAssertionType() above.

[Chris Dumez]

Created attachment 397114 [details]
Patch

[Geoffrey Garen]

Comment on attachment 397114 [details]
Patch

r=me

[EWS]

Committed r260453: <https://trac.webkit.org/changeset/260453>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397114 [details].

[Sam Weinig]

Comment on attachment 397114 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397114&action=review

> Source/WebKit/UIProcess/ProcessThrottler.cpp:115
> +        case ProcessAssertionType::UnboundedNetworking:
> +        case ProcessAssertionType::MediaPlayback:
> +        case ProcessAssertionType::DependentProcessLink:

Thumbs up.