Bug 210792 - [GTK][CMake] Make gtk-unix-print a component of FindGTK.cmake
Summary: [GTK][CMake] Make gtk-unix-print a component of FindGTK.cmake
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks: GTK4
  Show dependency tree / graph
 
Reported: 2020-04-21 05:46 PDT by Adrian Perez
Modified: 2020-04-21 08:27 PDT (History)
11 users (show)

See Also:

Attachments
Patch (6.75 KB, patch)
2020-04-21 05:49 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
Patch v2 (9.84 KB, patch)
2020-04-21 06:00 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
Patch for landing (9.90 KB, patch)
2020-04-21 08:02 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2020-04-21 05:46:22 PDT 
Instead of having “FindGTKUnixPrint.cmake” as a separate CMake
find-module, let's make it a component of “FindGTK.cmake”. This
will prevent desync between both .cmake files which can cause
weirdness like e.g. configuring the build with USE_GTK4=ON and
having GTK3 include paths in the build which were brought in
by “FindGTKUnixPrint.cmake” which is still checking for 3.x
Comment 1 Adrian Perez 2020-04-21 05:49:07 PDT 
Created attachment 397074 [details]
Patch
Comment 2 Adrian Perez 2020-04-21 05:53:45 PDT 
(In reply to Adrian Perez from comment #1)
> Created attachment 397074 [details]
> Patch

This is missing the changes to use the imported target inside the
following files:

 - Source/WebKit/PlatformGTK.cmake
 - Tools/TestWebKitAPI/glib/PlatformGTK.cmake

I'll upload an updated patch momentarily.
Comment 3 Adrian Perez 2020-04-21 06:00:47 PDT 
Created attachment 397075 [details]
Patch v2
Comment 4 EWS 2020-04-21 07:24:22 PDT 
/Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 5 Adrian Perez 2020-04-21 08:02:09 PDT 
Created attachment 397082 [details]
Patch for landing
Comment 6 EWS 2020-04-21 08:26:57 PDT 
Committed r260427: <https://trac.webkit.org/changeset/260427>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397082 [details].
Comment 7 Radar WebKit Bug Importer 2020-04-21 08:27:17 PDT 
<rdar://problem/62109307>