Instead of having “FindGTKUnixPrint.cmake” as a separate CMake
find-module, let's make it a component of “FindGTK.cmake”. This
will prevent desync between both .cmake files which can cause
weirdness like e.g. configuring the build with USE_GTK4=ON and
having GTK3 include paths in the build which were brought in
by “FindGTKUnixPrint.cmake” which is still checking for 3.x
Created attachment 397074 [details]
(In reply to Adrian Perez from comment #1)
> Created attachment 397074 [details]
This is missing the changes to use the imported target inside the
I'll upload an updated patch momentarily.
Created attachment 397075 [details]
/Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Created attachment 397082 [details]
Patch for landing
Committed r260427: <https://trac.webkit.org/changeset/260427>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 397082 [details].