Bug 210791 - [css-flexbox] The percentage height resolution quirk shouldn't be applied to flexboxes
Summary: [css-flexbox] The percentage height resolution quirk shouldn't be applied to ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BrowserCompat, InRadar, WPTImpact
Depends on:
Blocks:
 
Reported: 2020-04-21 05:02 PDT by Carlos Alberto Lopez Perez
Modified: 2024-03-04 15:54 PST (History)
15 users (show)

See Also:

Attachments
Patch (16.30 KB, patch)
2021-07-23 11:56 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (15.93 KB, patch)
2021-07-23 13:39 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (15.99 KB, patch)
2021-07-24 00:10 PDT, Rob Buis 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2020-04-21 05:02:48 PDT 
The following WPT test fails on WebKit: https://wpt.live/css/css-flexbox/quirks-auto-block-size-with-percentage-item.html

This test will pass if strict mode its enabled instead of quirks:

--- a/css/css-flexbox/quirks-auto-block-size-with-percentage-item.html
+++ b/css/css-flexbox/quirks-auto-block-size-with-percentage-item.html
@@ -1,4 +1,4 @@
-<!-- quirks mode -->
+<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
 <link rel="author" title="Morten Stenshorne" href="mailto:mstensho@chromium.org">
 <link rel="help" href="https://www.w3.org/TR/CSS22/visudet.html#the-height-property">
 <meta name="assert" content="The percentage height resolution quirk isn't applied to flexboxes.">


This passes on both Firefox and Chrome.

See also bug 210243
Comment 1 Philip Jägenstedt 2020-12-10 00:27:03 PST 
I believe that this Safari-only test failure is also because of this bug:
https://wpt.fyi/results/quirks/percentage-height-quirk-excludes-flex-grid-001.html
Comment 2 Rob Buis 2021-07-23 11:56:18 PDT 
Created attachment 434108 [details]
Patch
Comment 3 Rob Buis 2021-07-23 13:39:57 PDT 
Created attachment 434116 [details]
Patch
Comment 4 EWS Watchlist 2021-07-23 13:40:55 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 5 Rob Buis 2021-07-24 00:10:49 PDT 
Created attachment 434160 [details]
Patch
Comment 6 Ahmad Saleem 2022-09-18 04:52:03 PDT 
Safari Technology Preview 153 is only browser failing this test:

https://wpt.fyi/results/quirks/percentage-height-quirk-excludes-flex-grid-001.html?label=experimental&label=master&aligned

Is something planned or in queue? Thanks!
Comment 7 Radar WebKit Bug Importer 2024-02-08 13:17:00 PST 
<rdar://problem/122574943>
Comment 8 Sammy Gill 2024-03-04 15:33:46 PST 
We pass css-flexbox/quirks-auto-block-size-with-percentage-item.html now but looks like we are failing the row flexbox portion of https://wpt.fyi/results/quirks/percentage-height-quirk-excludes-flex-grid-001.html
Comment 9 Ahmad Saleem 2024-03-04 15:54:58 PST 
(In reply to Sammy Gill from comment #8)
> We pass css-flexbox/quirks-auto-block-size-with-percentage-item.html now but
> looks like we are failing the row flexbox portion of
> https://wpt.fyi/results/quirks/percentage-height-quirk-excludes-flex-grid-
> 001.html

NOTE - I tried this PR in the past and have background discussion as well (it is based of Rob's patch):

https://github.com/WebKit/WebKit/pull/16581

It leads to failing `datalist-searchinput-appearance.html` test with just change in 'DumpTree' output but rendering-wise, we don't have any issue.