Bug 210785 - [Win] Use generic WorkQueue instead of WorkQueueWin.cpp
Summary: [Win] Use generic WorkQueue instead of WorkQueueWin.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-20 23:20 PDT by Fujii Hironori
Modified: 2020-04-21 17:31 PDT (History)
13 users (show)

See Also:

Attachments
WIP patch (11.57 KB, patch)
2020-04-20 23:20 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (13.24 KB, patch)
2020-04-21 14:26 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch for landing (13.02 KB, patch)
2020-04-21 16:46 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2020-04-20 23:20:26 PDT 
[Win] Use generic WorkQueue instead of WorkQueueWin.cpp
Comment 1 Fujii Hironori 2020-04-20 23:20:43 PDT 
Created attachment 397056 [details]
WIP patch
Comment 2 Fujii Hironori 2020-04-21 14:22:06 PDT 
WorkQueueWin is using random threads to executing dispatched
functions. This is not desired for IPC::Connection because it
need to call CancelIo API in the thread started aync ReadFile
operations. (Bug 209847 Comment 25)
Comment 3 Fujii Hironori 2020-04-21 14:26:38 PDT 
Created attachment 397120 [details]
Patch
Comment 4 Darin Adler 2020-04-21 14:38:01 PDT 
Comment on attachment 397120 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397120&action=review

> Source/WTF/wtf/WorkQueue.h:35
> -#if USE(COCOA_EVENT_LOOP)
> +#if PLATFORM(COCOA)

Why is this a good change? Our overall plan is to eventually cut PLATFORM(XXX) down to an absolute minimum. Seems sad to move in the other direction.
Comment 5 Fujii Hironori 2020-04-21 15:03:48 PDT 
Comment on attachment 397120 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397120&action=review

Thank you for the review.

>> Source/WTF/wtf/WorkQueue.h:35
>> +#if PLATFORM(COCOA)
> 
> Why is this a good change? Our overall plan is to eventually cut PLATFORM(XXX) down to an absolute minimum. Seems sad to move in the other direction.

Agreed. Will fix.
I think USE_*_EVENT_LOOP macros should be refined. But it is another topic.
Comment 6 Fujii Hironori 2020-04-21 16:46:25 PDT 
Created attachment 397139 [details]
Patch for landing
Comment 7 Fujii Hironori 2020-04-21 17:30:00 PDT 
Comment on attachment 397139 [details]
Patch for landing

Clearing flags on attachment: 397139

Committed r260477: <https://trac.webkit.org/changeset/260477>
Comment 8 Fujii Hironori 2020-04-21 17:30:03 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2020-04-21 17:31:14 PDT 
<rdar://problem/62140869>