Bug 210774 – Support toggling debug overlay for touch action region and editable element region independent from non-fast scrollable region

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Daniel Bates]

Support toggling debug overlay for touch action region and editable element region independent from non-fast scrollable region. Currently both of these are tied into the setting for painting the non-fast scrollable region. Separate them out to support opting into the combinations of overlays each person is interested in at the moment.

[Daniel Bates]

Created attachment 397038 [details]
Patch

[Daniel Bates]

Comment on attachment 397038 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397038&action=review

> Source/WebCore/rendering/RenderLayer.cpp:7055
> +        if (renderer().settings().visibleDebugOverlayRegions() & (TouchActionRegion | EditableElementRegion))

I wanted to make this setting return an OptionSet<>, but that involves some work due to how settings are generated. For now, I deferred this.

[Dean Jackson]

Comment on attachment 397038 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397038&action=review

> Source/WebCore/ChangeLog:8
> +        Break out the touch action region and editable element region debug overlays into there own

their

> Source/WebCore/ChangeLog:19
> +        (WebCore::RenderLayerBacking::paintDebugOverlays): Condition the paintinf of touch action region

painting

>> Source/WebCore/rendering/RenderLayer.cpp:7055
>> +        if (renderer().settings().visibleDebugOverlayRegions() & (TouchActionRegion | EditableElementRegion))
> 
> I wanted to make this setting return an OptionSet<>, but that involves some work due to how settings are generated. For now, I deferred this.

Yeah, that's a shame. It's ok as a mask though.

> Source/WebCore/rendering/RenderLayerBacking.cpp:3088
> +        Color regionColor(0, 0, 255, 50);

At some point in the future we should collect all our colors into a single place so we can document them easily.

[Daniel Bates]

Created attachment 397296 [details]
To Land

[Daniel Bates]

Committed r260547: <https://trac.webkit.org/changeset/260547>

[Radar WebKit Bug Importer]

<rdar://problem/62222660>