Bug 210765 - Add more structure-cloning tests for BigInt
Summary: Add more structure-cloning tests for BigInt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-20 13:40 PDT by Yusuke Suzuki
Modified: 2020-04-20 15:34 PDT (History)
6 users (show)

See Also:

Attachments
WIP (5.96 KB, patch)
2020-04-20 14:00 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (9.15 KB, patch)
2020-04-20 14:28 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (12.40 KB, patch)
2020-04-20 14:34 PDT, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-04-20 13:40:09 PDT 
We should have tests outside of WPT too.
Comment 1 Yusuke Suzuki 2020-04-20 14:00:06 PDT 
Created attachment 397011 [details]
WIP

Patch for collecting expect files from GTK etc.
Comment 2 Yusuke Suzuki 2020-04-20 14:15:03 PDT 
(In reply to Yusuke Suzuki from comment #1)
> Created attachment 397011 [details]
> WIP
> 
> Patch for collecting expect files from GTK etc.

Ugh, GTK is not running tests in EWS.
Comment 3 Yusuke Suzuki 2020-04-20 14:28:42 PDT 
Created attachment 397017 [details]
Patch
Comment 4 Yusuke Suzuki 2020-04-20 14:34:27 PDT 
Created attachment 397018 [details]
Patch
Comment 5 Mark Lam 2020-04-20 14:40:08 PDT 
Comment on attachment 397018 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397018&action=review

r=me

> LayoutTests/fast/dom/Window/window-postmessage-clone.html:327
> +        'var i = Object(100000000000000000000n); ' +

There’s a comment above this that should be updated to include BigInt too.
Comment 6 Yusuke Suzuki 2020-04-20 14:40:30 PDT 
Comment on attachment 397018 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397018&action=review

Thanks!

>> LayoutTests/fast/dom/Window/window-postmessage-clone.html:327
>> +        'var i = Object(100000000000000000000n); ' +
> 
> There’s a comment above this that should be updated to include BigInt too.

Fixed.
Comment 7 Yusuke Suzuki 2020-04-20 15:26:29 PDT 
WK1 EWS is green and seems that this test is skipped in wk2. Landing.
Comment 8 Yusuke Suzuki 2020-04-20 15:33:06 PDT 
Committed r260404: <https://trac.webkit.org/changeset/260404>
Comment 9 Radar WebKit Bug Importer 2020-04-20 15:34:14 PDT 
<rdar://problem/62079013>