RESOLVED FIXED 210749
[JSC] Skip test262 for non-safe-integer range BigIntConstructor 
https://bugs.webkit.org/show_bug.cgi?id=210749
Summary [JSC] Skip test262 for non-safe-integer range BigIntConstructor
Yusuke Suzuki
Reported 2020-04-20 09:21:02 PDT
...
Attachments
Patch (6.16 KB, patch)
2020-04-20 11:02 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (1.74 KB, patch)
2020-04-20 11:29 PDT, Yusuke Suzuki 		keith_miller: review+
DetailsFormatted DiffDiff
Patch for landing (3.23 KB, patch)
2020-04-20 12:06 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-04-20 11:02:51 PDT
Created attachment 396993 [details] Patch
Yusuke Suzuki
Comment 2 2020-04-20 11:03:13 PDT
Comment on attachment 396993 [details] Patch This fixes trivial test262 failure.
Keith Miller
Comment 3 2020-04-20 11:05:47 PDT
Comment on attachment 396993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396993&action=review r=me with nit. > Source/JavaScriptCore/ChangeLog:8 > + Maybe, the spec is changed at some point, and now BigInt constructor accepts non-safe-integers. Nit, I would phrase this as: Maybe the spec changed at some point but BigInt constructor accepts non-safe-integers.
Yusuke Suzuki
Comment 4 2020-04-20 11:29:37 PDT
Created attachment 396994 [details] Patch
Keith Miller
Comment 5 2020-04-20 11:38:08 PDT
Comment on attachment 396994 [details] Patch Can we file a bug and put a FIXME in our BigInt constructor?
Yusuke Suzuki
Comment 6 2020-04-20 11:40:05 PDT
(In reply to Keith Miller from comment #5) > Comment on attachment 396994 [details] > Patch > > Can we file a bug and put a FIXME in our BigInt constructor? https://bugs.webkit.org/show_bug.cgi?id=210755 Filed. And added FIXME.
Yusuke Suzuki
Comment 7 2020-04-20 12:03:55 PDT
Tested test262 locally since it is not included in EWS.
Yusuke Suzuki
Comment 8 2020-04-20 12:06:26 PDT
Created attachment 396998 [details] Patch for landing Patch for landing
Yusuke Suzuki
Comment 9 2020-04-20 12:11:55 PDT
Committed r260384: <https://trac.webkit.org/changeset/260384>
Radar WebKit Bug Importer
Comment 10 2020-04-20 12:12:17 PDT
<rdar://problem/62069585>
Note You need to log in before you can comment on or make changes to this bug.