Bug 210749 - [JSC] Skip test262 for non-safe-integer range BigIntConstructor
Summary: [JSC] Skip test262 for non-safe-integer range BigIntConstructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-20 09:21 PDT by Yusuke Suzuki
Modified: 2020-04-20 12:12 PDT (History)
7 users (show)

See Also:

Attachments
Patch (6.16 KB, patch)
2020-04-20 11:02 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (1.74 KB, patch)
2020-04-20 11:29 PDT, Yusuke Suzuki 		keith_miller: review+
Details | Formatted Diff | Diff
Patch for landing (3.23 KB, patch)
2020-04-20 12:06 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-04-20 09:21:02 PDT 
...
Comment 1 Yusuke Suzuki 2020-04-20 11:02:51 PDT 
Created attachment 396993 [details]
Patch
Comment 2 Yusuke Suzuki 2020-04-20 11:03:13 PDT 
Comment on attachment 396993 [details]
Patch

This fixes trivial test262 failure.
Comment 3 Keith Miller 2020-04-20 11:05:47 PDT 
Comment on attachment 396993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396993&action=review

r=me with nit.

> Source/JavaScriptCore/ChangeLog:8
> +        Maybe, the spec is changed at some point, and now BigInt constructor accepts non-safe-integers.

Nit, I would phrase this as: Maybe the spec changed at some point but BigInt constructor accepts non-safe-integers.
Comment 4 Yusuke Suzuki 2020-04-20 11:29:37 PDT 
Created attachment 396994 [details]
Patch
Comment 5 Keith Miller 2020-04-20 11:38:08 PDT 
Comment on attachment 396994 [details]
Patch

Can we file a bug and put a FIXME in our BigInt constructor?
Comment 6 Yusuke Suzuki 2020-04-20 11:40:05 PDT 
(In reply to Keith Miller from comment #5)
> Comment on attachment 396994 [details]
> Patch
> 
> Can we file a bug and put a FIXME in our BigInt constructor?

https://bugs.webkit.org/show_bug.cgi?id=210755 Filed. And added FIXME.
Comment 7 Yusuke Suzuki 2020-04-20 12:03:55 PDT 
Tested test262 locally since it is not included in EWS.
Comment 8 Yusuke Suzuki 2020-04-20 12:06:26 PDT 
Created attachment 396998 [details]
Patch for landing

Patch for landing
Comment 9 Yusuke Suzuki 2020-04-20 12:11:55 PDT 
Committed r260384: <https://trac.webkit.org/changeset/260384>
Comment 10 Radar WebKit Bug Importer 2020-04-20 12:12:17 PDT 
<rdar://problem/62069585>