Bug 210748 - [Clang 10] Fix warning: definition of implicit copy assignment operator for 'PageBlock' is deprecated because it has a user-declared copy constructor
Summary: [Clang 10] Fix warning: definition of implicit copy assignment operator for '...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Charlie Turner
Depends on:
Reported: 2020-04-20 08:22 PDT by Charlie Turner
Modified: 2020-04-21 09:21 PDT (History)
7 users (show)

See Also:

Patch (2.96 KB, patch)
2020-04-20 10:43 PDT, Charlie Turner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Charlie Turner 2020-04-20 08:22:39 PDT
This warning was spamming the build process a lot.
Comment 1 Charlie Turner 2020-04-20 10:43:33 PDT
Created attachment 396990 [details]
Comment 2 Adrian Perez 2020-04-21 04:21:37 PDT
Patch LGTM, I am tempted to r+ given that all the EWS builders
are green, but would be more confident if someone else would also
take a quick look as this is fairly low-level code 🤔️
Comment 3 Adrian Perez 2020-04-21 04:28:37 PDT
Comment on attachment 396990 [details]

Let's wait until tomorrow to land this in case someone else wants to take a
look, but the more I stare at it, the more I am convinced it's all right :D
Comment 4 Darin Adler 2020-04-21 08:57:00 PDT
Looks right to me.
Comment 5 EWS 2020-04-21 09:21:35 PDT
Committed r260431: <https://trac.webkit.org/changeset/260431>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396990 [details].