Bug 210727 - [JSC] SlowPathCall is not supported by callOperation in Windows
Summary: [JSC] SlowPathCall is not supported by callOperation in Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-19 18:13 PDT by Yusuke Suzuki
Modified: 2020-04-19 18:57 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.86 KB, patch)
2020-04-19 18:15 PDT, Yusuke Suzuki 		ross.kirsling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-04-19 18:13:04 PDT 
Baseline JIT should use JITSlowPathCall.
Comment 1 Yusuke Suzuki 2020-04-19 18:15:50 PDT 
Created attachment 396932 [details]
Patch
Comment 2 Ross Kirsling 2020-04-19 18:50:18 PDT 
Comment on attachment 396932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396932&action=review

> Source/JavaScriptCore/jit/SlowPathCall.h:68
> +        static_assert(JIT::regT0 == GPRInfo::returnValueGPR);
> +        static_assert(JIT::regT1 == GPRInfo::returnValueGPR2);

Should we update this instead?
https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/jit/GPRInfo.h#L796-L799
Comment 3 Yusuke Suzuki 2020-04-19 18:51:43 PDT 
Comment on attachment 396932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396932&action=review

>> Source/JavaScriptCore/jit/SlowPathCall.h:68
>> +        static_assert(JIT::regT1 == GPRInfo::returnValueGPR2);
> 
> Should we update this instead?
> https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/jit/GPRInfo.h#L796-L799

For non-Windows x64, returnValueGPR2 is not regT1. We are using this static_assert only inside `OS(WINDOWS)`.
Comment 4 Yusuke Suzuki 2020-04-19 18:56:30 PDT 
Committed r260346: <https://trac.webkit.org/changeset/260346>
Comment 5 Radar WebKit Bug Importer 2020-04-19 18:57:16 PDT 
<rdar://problem/62037858>