Bug 210715 - Fix missing exception checks and handling in JSC APIs.
Summary: Fix missing exception checks and handling in JSC APIs.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-19 01:03 PDT by Mark Lam
Modified: 2020-04-19 14:18 PDT (History)
8 users (show)

See Also:

Attachments
proposed patch. (14.05 KB, patch)
2020-04-19 01:08 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
proposed patch. (17.92 KB, patch)
2020-04-19 11:56 PDT, Mark Lam 		saam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2020-04-19 01:03:57 PDT 
<rdar://problem/61599658>
Comment 1 Mark Lam 2020-04-19 01:08:58 PDT 
Created attachment 396897 [details]
proposed patch.
Comment 2 Mark Lam 2020-04-19 02:15:04 PDT 
Comment on attachment 396897 [details]
proposed patch.

Need a bit more work.  New patch coming.
Comment 3 Mark Lam 2020-04-19 11:56:52 PDT 
Created attachment 396920 [details]
proposed patch.
Comment 4 Saam Barati 2020-04-19 13:44:38 PDT 
Comment on attachment 396920 [details]
proposed patch.

Can you add tests for all this?
Comment 5 Mark Lam 2020-04-19 14:09:37 PDT 
(In reply to Saam Barati from comment #4)
> Comment on attachment 396920 [details]
> proposed patch.
> 
> Can you add tests for all this?

I already tried but am not able to.  It was trickier than it looked on the surface.  The result keep coming back as undefined when an exception is thrown.  I filed https://bugs.webkit.org/show_bug.cgi?id=210725 to investigate this later.
Comment 6 Mark Lam 2020-04-19 14:18:52 PDT 
Thanks for the review.  Landed in r260343: <http://trac.webkit.org/r260343>.