Leak of RBSAssertionInvalidationCallbackType due to missing -dealloc. Found by clang static analyzer: 'WKRBSAssertionDelegate' lacks a 'dealloc' instance method but must release '_invalidationCallback' Regressed with the fix for Bug 210065 in r259610: Bug 196659: [iOS] Transition most process assertions to RunningBoard <https://bugs.webkit.org/show_bug.cgi?id=210065> <rdar://problem/61354901> <https://trac.webkit.org/r259610>
<rdar://problem/61993361>
Created attachment 396889 [details] Patch v1
Comment on attachment 396889 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=396889&action=review > Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:275 > +- (void)dealloc I chose to implement dealloc because using RetainPtr<> would require an instance variable and a custom getter (and maybe a setter). When switching to ARC, we simply delete the -dealloc method and the @property will work as expected.
Comment on attachment 396889 [details] Patch v1 r=me
Created attachment 396933 [details] Patch for landing
Created attachment 396934 [details] Patch for landing v2
Found 1 new test failure: fast/layoutformattingcontext/simple-absolute-positioned-replaced-inline-element-with-percentage-height.html
Committed r260354: <https://trac.webkit.org/changeset/260354> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396934 [details].