Bug 210709 - Fix CLoop build for iterator opcodes
Summary: Fix CLoop build for iterator opcodes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-18 19:05 PDT by Keith Miller
Modified: 2020-04-18 20:44 PDT (History)
7 users (show)

See Also:

Attachments
Patch (7.44 KB, patch)
2020-04-18 19:07 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (8.88 KB, patch)
2020-04-18 19:22 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (8.60 KB, patch)
2020-04-18 19:42 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2020-04-18 19:05:37 PDT 
Fix CLoop build for iterator opcodes
Comment 1 Keith Miller 2020-04-18 19:07:07 PDT 
Created attachment 396884 [details]
Patch
Comment 2 Robin Morisset 2020-04-18 19:08:44 PDT 
Comment on attachment 396884 [details]
Patch

r=me
Comment 3 Robin Morisset 2020-04-18 19:12:19 PDT 
Comment on attachment 396884 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396884&action=review

> Source/JavaScriptCore/bytecode/BytecodeList.rb:1326
> +op :llint_cloop_did_return_from_js_46

I was too fast in r+-ing this patch, I think it is missing matching code in Bytecodes.h. Look for macro(llint_cloop_did_return_from_js_1, 1), and add similar ones for the new ops you are adding.
Comment 4 Keith Miller 2020-04-18 19:13:23 PDT 
(In reply to Robin Morisset from comment #3)
> Comment on attachment 396884 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=396884&action=review
> 
> > Source/JavaScriptCore/bytecode/BytecodeList.rb:1326
> > +op :llint_cloop_did_return_from_js_46
> 
> I was too fast in r+-ing this patch, I think it is missing matching code in
> Bytecodes.h. Look for macro(llint_cloop_did_return_from_js_1, 1), and add
> similar ones for the new ops you are adding.

Isn't Bytecodes.h auto generated?
Comment 5 Keith Miller 2020-04-18 19:13:47 PDT 
Looks like I need to generate superfluous labels for 32-bit...
Comment 6 Keith Miller 2020-04-18 19:22:07 PDT 
Created attachment 396885 [details]
Patch for landing
Comment 7 Keith Miller 2020-04-18 19:42:11 PDT 
Created attachment 396888 [details]
Patch for landing
Comment 8 EWS 2020-04-18 20:43:52 PDT 
Committed r260333: <https://trac.webkit.org/changeset/260333>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396888 [details].
Comment 9 Radar WebKit Bug Importer 2020-04-18 20:44:15 PDT 
<rdar://problem/61995365>