Bug 210707 - CSS env variables are exposed in getComputedStyle enumeration.
Summary: CSS env variables are exposed in getComputedStyle enumeration.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emilio Cobos Álvarez (:emilio)
URL:
Keywords: InRadar, WebExposed
Depends on: 210695
Blocks:
  Show dependency tree / graph
 
Reported: 2020-04-18 17:27 PDT by Emilio Cobos Álvarez (:emilio)
Modified: 2020-05-10 18:45 PDT (History)
11 users (show)

See Also:

Attachments
Patch (7.53 KB, patch)
2020-04-18 17:50 PDT, Emilio Cobos Álvarez (:emilio) 		no flags Details | Formatted Diff | Diff
Patch for landing (8.59 KB, patch)
2020-04-19 07:21 PDT, Emilio Cobos Álvarez (:emilio) 		no flags Details | Formatted Diff | Diff
Patch for landing (8.59 KB, patch)
2020-04-19 07:23 PDT, Emilio Cobos Álvarez (:emilio) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emilio Cobos Álvarez (:emilio) 2020-04-18 17:27:30 PDT 
Similar to to bug 210695. WebKit stores the env variable values in the inherited properties.
Comment 1 Emilio Cobos Álvarez (:emilio) 2020-04-18 17:50:17 PDT 
Created attachment 396880 [details]
Patch
Comment 2 Emilio Cobos Álvarez (:emilio) 2020-04-19 07:21:01 PDT 
Created attachment 396906 [details]
Patch for landing
Comment 3 EWS 2020-04-19 07:21:45 PDT 
Annti Koivisto found in /Volumes/Data/worker/Commit-Queue/build/LayoutTests/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/worker/Commit-Queue/build/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 4 Emilio Cobos Álvarez (:emilio) 2020-04-19 07:22:55 PDT 
Whoops, that happens for filing the changelog manually :)
Comment 5 Emilio Cobos Álvarez (:emilio) 2020-04-19 07:23:16 PDT 
Created attachment 396907 [details]
Patch for landing
Comment 6 EWS 2020-04-19 08:55:04 PDT 
Found 1 new test failure: fast/layoutformattingcontext/simple-absolute-positioned-replaced-inline-element-with-percentage-height.html
Comment 7 Emilio Cobos Álvarez (:emilio) 2020-04-19 10:59:31 PDT 
Comment on attachment 396907 [details]
Patch for landing

Doesn't look related.
Comment 8 EWS 2020-04-19 11:01:22 PDT 
Committed r260340: <https://trac.webkit.org/changeset/260340>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396907 [details].