Currently in DumpRenderTree the CMakeLists.txt has definitions for TestNetscapePlugin but also there's a root CMakeLists.txt in that directory.
Created attachment 396857 [details] WIP Patch
Created attachment 396858 [details] WIP Patch
Created attachment 396859 [details] Patch
Created attachment 396860 [details] Patch
Created attachment 396862 [details] Patch
Comment on attachment 396862 [details] Patch The AppleWin build is failing but I think it just needs a clean build.
Comment on attachment 396862 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396862&action=review > Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:49 > +WEBKIT_FRAMEWORK(TestNetscapePlugIn) You use WEBKIT_FRAMEWORK, but you don't set TestNetscapePlugIn_LIBRARY_TYPE to SHARED. Do you specify it anywhere?
Created attachment 396911 [details] Patch
Created attachment 396913 [details] Patch
Committed r260341: <https://trac.webkit.org/changeset/260341> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396913 [details].