Bug 210668 - Reduce parameter list of the FrameLoadRequest constructor
Summary: Reduce parameter list of the FrameLoadRequest constructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-17 13:41 PDT by Rob Buis
Modified: 2020-04-18 10:05 PDT (History)
7 users (show)

See Also:

Attachments
Patch (50.65 KB, patch)
2020-04-17 13:51 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2020-04-17 13:41:35 PDT 
Reduce parameter list of the FrameLoadRequest constructor.
Comment 1 Rob Buis 2020-04-17 13:51:25 PDT 
Created attachment 396792 [details]
Patch
Comment 2 Rob Buis 2020-04-17 14:32:16 PDT 
Comment on attachment 396792 [details]
Patch

Note that the parameter list can be reduced more or less, this is a somewhat arbitrary length. It is also possible that some of the remaining parameters are better candidates for setters.
Comment 3 EWS 2020-04-18 10:04:11 PDT 
Committed r260317: <https://trac.webkit.org/changeset/260317>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396792 [details].
Comment 4 Radar WebKit Bug Importer 2020-04-18 10:05:23 PDT 
<rdar://problem/61975226>