Bug 210667 - [JSC] We do not need to have exit-check for Map/Set iterator functions
Summary: [JSC] We do not need to have exit-check for Map/Set iterator functions
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on: 210678
Blocks:
  Show dependency tree / graph
 
Reported: 2020-04-17 13:13 PDT by Yusuke Suzuki
Modified: 2020-04-18 14:17 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.13 KB, patch)
2020-04-17 13:16 PDT, Yusuke Suzuki 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-04-17 13:13:56 PDT 
[JSC] We do not need to have exit-check for Map/Set iterator functions
Comment 1 Yusuke Suzuki 2020-04-17 13:16:21 PDT 
Created attachment 396788 [details]
Patch
Comment 2 Michael Saboff 2020-04-17 13:52:18 PDT 
Comment on attachment 396788 [details]
Patch

r=me
Comment 3 Yusuke Suzuki 2020-04-17 14:03:13 PDT 
Committed r260279: <https://trac.webkit.org/changeset/260279>
Comment 4 Radar WebKit Bug Importer 2020-04-17 14:04:14 PDT 
<rdar://problem/61949524>
Comment 5 Saam Barati 2020-04-17 15:53:38 PDT 
Comment on attachment 396788 [details]
Patch

But throwing an exception is something the compiler can handle. Exitting always will pessimize the code to a lower tier
Comment 6 Yusuke Suzuki 2020-04-17 15:59:22 PDT 
(In reply to Saam Barati from comment #5)
> Comment on attachment 396788 [details]
> Patch
> 
> But throwing an exception is something the compiler can handle. Exitting
> always will pessimize the code to a lower tier

Oh, interesting. So maybe we should keep this thing.
Comment 7 WebKit Commit Bot 2020-04-17 16:00:28 PDT 
Re-opened since this is blocked by bug 210678