Bug 210662 - Bring Fullscreen API + alert() behavior from iOS to macOS
Summary: Bring Fullscreen API + alert() behavior from iOS to macOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-17 11:20 PDT by Jer Noble
Modified: 2020-04-17 15:44 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.79 KB, patch)
2020-04-17 11:23 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (10.43 KB, patch)
2020-04-17 12:07 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2020-04-17 11:20:12 PDT 
Bring Fullscreen API + alert() behavior from iOS to macOS
Comment 1 Jer Noble 2020-04-17 11:23:44 PDT 
Created attachment 396777 [details]
Patch
Comment 2 Darin Adler 2020-04-17 11:24:58 PDT 
Comment on attachment 396777 [details]
Patch

Regression test?
Comment 3 Jer Noble 2020-04-17 11:35:43 PDT 
We should be able to write an API test for both macOS and iOS verifying that we exit fullscreen mode when the page fires an alert(). Will add before landing.
Comment 4 Jer Noble 2020-04-17 12:07:53 PDT 
Created attachment 396779 [details]
Patch for landing
Comment 5 Jer Noble 2020-04-17 12:44:20 PDT 
<rdar://problem/60684195>
Comment 6 EWS 2020-04-17 13:41:15 PDT 
Committed r260278: <https://trac.webkit.org/changeset/260278>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396779 [details].