Bug 210641 – Reduce test iterations for stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js on mips

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Paulo Matos]

Reduce test iterations for mips

[Paulo Matos]

Created attachment 396745 [details]
Patch

[Paulo Matos]

Created attachment 396746 [details]
Patch

[Caio Lima]

Comment on attachment 396746 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396746&action=review

> JSTests/stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js:4
> +iterations = typeof(iterations) === 'undefined' ? 10000000 : iterations;

It is possible to use `iterations = iterations === undefined ? 10000000 : iterations;`

[Paulo Matos]

(In reply to Caio Lima from comment #3)
> Comment on attachment 396746 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=396746&action=review
> 
> > JSTests/stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js:4
> > +iterations = typeof(iterations) === 'undefined' ? 10000000 : iterations;
> 
> It is possible to use `iterations = iterations === undefined ? 10000000 :
> iterations;`

After discussing elsewhere with Caio on this, we decided to keep as is since other parts of the codebase use the `typeof(X) === 'undefined'` style.

[Yusuke Suzuki]

Comment on attachment 396746 [details]
Patch

r=me

[EWS]

Committed r260253: <https://trac.webkit.org/changeset/260253>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396746 [details].

[Radar WebKit Bug Importer]

<rdar://problem/61936417>