Bug 210631 - GetTypedArrayByteOffset is broken on arm64e
Summary: GetTypedArrayByteOffset is broken on arm64e
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-16 19:11 PDT by Saam Barati
Modified: 2020-04-17 14:49 PDT (History)
16 users (show)

See Also:

Attachments
patch (8.75 KB, patch)
2020-04-16 19:26 PDT, Saam Barati 		mark.lam: review+
Details | Formatted Diff | Diff
patch for landing (7.99 KB, patch)
2020-04-17 11:00 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch for landing (7.99 KB, patch)
2020-04-17 11:00 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-04-16 19:11:32 PDT 
- We compare against 0 instead of the "null" signed vector
Comment 1 Saam Barati 2020-04-16 19:26:30 PDT 
Created attachment 396733 [details]
patch
Comment 2 Mark Lam 2020-04-16 19:43:53 PDT 
Comment on attachment 396733 [details]
patch

r=me
Comment 3 Saam Barati 2020-04-17 08:58:43 PDT 
Seems like my change breaks byteOffset in C++. Question is: is that same branch also broken in JITCode or is DataView unreachable?
Comment 4 Saam Barati 2020-04-17 10:57:14 PDT 
(In reply to Saam Barati from comment #3)
> Seems like my change breaks byteOffset in C++. Question is: is that same
> branch also broken in JITCode or is DataView unreachable?

Yeah, not reachable.
Comment 5 Saam Barati 2020-04-17 11:00:04 PDT 
Created attachment 396774 [details]
patch for landing
Comment 6 Saam Barati 2020-04-17 11:00:58 PDT 
Created attachment 396775 [details]
patch for landing
Comment 7 EWS 2020-04-17 14:48:26 PDT 
Committed r260289: <https://trac.webkit.org/changeset/260289>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396775 [details].
Comment 8 Radar WebKit Bug Importer 2020-04-17 14:49:16 PDT 
<rdar://problem/61951457>