NetworkSessionCocoa should request client certificate only once per host/port
Created attachment 396718 [details] Patch
<rdar://problem/60340449>
Created attachment 396735 [details] Patch
Created attachment 396781 [details] Patch
Created attachment 396787 [details] Patch
Created attachment 396794 [details] Patch
Comment on attachment 396794 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396794&action=review r=me > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h:161 > + HashMap<std::pair<String, uint16_t>, RetainPtr<NSURLCredential>> m_successfulClientCertificates; Can we give a name to "std::pair<String, uint16_t>", and maybe use it in SuggestedClientCertificate too? Something like "Server" or "Endpoint" or just "HostAndPort". Maybe just make it a struct rather than a pair. > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1037 > + if (UNLIKELY(!m_suggestedClientCertificates.isEmpty())) { Can be an early return to reduce nesting.
Created attachment 396809 [details] Patch
Created attachment 396811 [details] Patch
Created attachment 396815 [details] Patch
http://trac.webkit.org/r260302