Bug 210624 - Add some more tests for -focusTextInputContext:placeCaretAt:completionHandler:
Summary: Add some more tests for -focusTextInputContext:placeCaretAt:completionHandler:
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-16 15:54 PDT by Daniel Bates
Modified: 2020-04-18 16:21 PDT (History)
2 users (show)

See Also:

Attachments
More tests (10.59 KB, patch)
2020-04-16 16:14 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
More tests (10.67 KB, patch)
2020-04-16 16:21 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
To Land (10.72 KB, patch)
2020-04-18 16:20 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2020-04-16 15:54:54 PDT 
Add some more tests for -focusTextInputContext:placeCaretAt:completionHandler:.
Comment 1 Daniel Bates 2020-04-16 16:14:47 PDT 
Created attachment 396715 [details]
More tests
Comment 2 Daniel Bates 2020-04-16 16:20:54 PDT 
Comment on attachment 396715 [details]
More tests

View in context: https://bugs.webkit.org/attachment.cgi?id=396715&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:322
> +    EXPECT_EQ(1, [[webView objectByEvaluatingJavaScript:@"document.activeElement.selectionStart"] intValue]);

This is wrong. It doesn't set the selection. I lost my change!
Comment 3 Daniel Bates 2020-04-16 16:21:13 PDT 
Created attachment 396716 [details]
More tests
Comment 4 Daniel Bates 2020-04-16 16:26:58 PDT 
Comment on attachment 396716 [details]
More tests

View in context: https://bugs.webkit.org/attachment.cgi?id=396716&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:326
> +    // Use -focusTextInputContext: to place the caret the beginning of the field; no change because the field is already focused.

"caret the" => caret at the
Comment 5 Daniel Bates 2020-04-18 16:20:07 PDT 
Created attachment 396871 [details]
To Land
Comment 6 Daniel Bates 2020-04-18 16:20:28 PDT 
Committed r260327: <https://trac.webkit.org/changeset/260327>
Comment 7 Radar WebKit Bug Importer 2020-04-18 16:21:13 PDT 
<rdar://problem/61987114>