Bug 210606 – Stop including style rules related to media controls in the UA style sheet when Modern Media Controls are enabled

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Antoine Quint]

Stop including style rules related to media controls in the UA style sheet when Modern Media Controls are enabled

[Antoine Quint]

Created attachment 396654 [details]
Patch

[Antoine Quint]

Created attachment 396764 [details]
Patch

[Daniel Bates]

Comment on attachment 396764 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396764&action=review

This patch looks good. A better patch would add tests for the UA stylesheet changes and the runtime enabled branch.

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:25
>  body:-webkit-full-page-media {

The optimal solution would remove this because it duplicates the style in html.css now. If it cannot be removed, why?

[Antoine Quint]

(In reply to Daniel Bates from comment #3)
> Comment on attachment 396764 [details]
> Patch
> 
> > Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:25
> >  body:-webkit-full-page-media {
> 
> The optimal solution would remove this because it duplicates the style in
> html.css now. If it cannot be removed, why?

It can, just an oversight!

[Antoine Quint]

Committed r260261: <https://trac.webkit.org/changeset/260261>

[Radar WebKit Bug Importer]

<rdar://problem/61940561>

[Ryan Haddad]

Follow up build fix in https://trac.webkit.org/changeset/260269/webkit

[Antoine Quint]

(In reply to Ryan Haddad from comment #7)
> Follow up build fix in https://trac.webkit.org/changeset/260269/webkit

Actually, this was for the wrong bug :) This was a bug fix for bug 210653.