Bug 210606 - Stop including style rules related to media controls in the UA style sheet when Modern Media Controls are enabled
Summary: Stop including style rules related to media controls in the UA style sheet wh...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-16 09:23 PDT by Antoine Quint
Modified: 2020-04-17 11:59 PDT (History)
14 users (show)

See Also:

Attachments
Patch (2.87 KB, patch)
2020-04-16 09:25 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (4.05 KB, patch)
2020-04-17 08:04 PDT, Antoine Quint 		dbates: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2020-04-16 09:23:05 PDT 
Stop including style rules related to media controls in the UA style sheet when Modern Media Controls are enabled
Comment 1 Antoine Quint 2020-04-16 09:25:24 PDT 
Created attachment 396654 [details]
Patch
Comment 2 Antoine Quint 2020-04-17 08:04:49 PDT 
Created attachment 396764 [details]
Patch
Comment 3 Daniel Bates 2020-04-17 08:18:27 PDT 
Comment on attachment 396764 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396764&action=review

This patch looks good. A better patch would add tests for the UA stylesheet changes and the runtime enabled branch.

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:25
>  body:-webkit-full-page-media {

The optimal solution would remove this because it duplicates the style in html.css now. If it cannot be removed, why?
Comment 4 Antoine Quint 2020-04-17 08:38:20 PDT 
(In reply to Daniel Bates from comment #3)
> Comment on attachment 396764 [details]
> Patch
> 
> > Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:25
> >  body:-webkit-full-page-media {
> 
> The optimal solution would remove this because it duplicates the style in
> html.css now. If it cannot be removed, why?

It can, just an oversight!
Comment 5 Antoine Quint 2020-04-17 10:24:30 PDT 
Committed r260261: <https://trac.webkit.org/changeset/260261>
Comment 6 Radar WebKit Bug Importer 2020-04-17 10:25:22 PDT 
<rdar://problem/61940561>
Comment 7 Ryan Haddad 2020-04-17 11:56:51 PDT 
Follow up build fix in https://trac.webkit.org/changeset/260269/webkit
Comment 8 Antoine Quint 2020-04-17 11:59:51 PDT 
(In reply to Ryan Haddad from comment #7)
> Follow up build fix in https://trac.webkit.org/changeset/260269/webkit

Actually, this was for the wrong bug :) This was a bug fix for bug 210653.